Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: tools/telemetry/telemetry/value/list_of_scalar_values.py

Issue 545523002: [Telemetry] Add capability for values to reference external files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better approach + more tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/value/list_of_scalar_values.py
diff --git a/tools/telemetry/telemetry/value/list_of_scalar_values.py b/tools/telemetry/telemetry/value/list_of_scalar_values.py
index 698957ad571e6a73aaf48d0b20572788af9af4f6..4107e7e87455932fa941cbd132e22e4dbee0d739 100644
--- a/tools/telemetry/telemetry/value/list_of_scalar_values.py
+++ b/tools/telemetry/telemetry/value/list_of_scalar_values.py
@@ -15,9 +15,9 @@ def _Mean(values):
class ListOfScalarValues(value_module.Value):
def __init__(self, page, name, units, values,
important=True, description=None, none_value_reason=None,
- same_page_merge_policy=value_module.CONCATENATE):
+ same_page_merge_policy=value_module.CONCATENATE, paths=None):
super(ListOfScalarValues, self).__init__(page, name, units, important,
- description)
+ description, paths)
if values is not None:
assert isinstance(values, list)
assert len(values) > 0
@@ -37,14 +37,16 @@ class ListOfScalarValues(value_module.Value):
else:
merge_policy = 'PICK_FIRST'
return ('ListOfScalarValues(%s, %s, %s, %s, '
- 'important=%s, description=%s, same_page_merge_policy=%s)') % (
+ 'important=%s, description=%s, same_page_merge_policy=%s, '
+ 'paths=%s)') % (
page_name,
self.name,
self.units,
repr(self.values),
self.important,
self.description,
- merge_policy)
+ merge_policy,
+ self.paths)
def GetBuildbotDataType(self, output_context):
if self._IsImportantGivenOutputIntent(output_context):

Powered by Google App Engine
This is Rietveld 408576698