tools/telemetry/telemetry/results/results_options.py - Issue 545523002: [Telemetry] Add capability for values to reference external files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/results/results_options.py

Issue 545523002: [Telemetry] Add capability for values to reference external files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work around GPU triggered tests not knowing about trace_viewer Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/json_output_formatter_unittest.py ('k') | tools/telemetry/telemetry/util/file_handle.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/results_options.py

diff --git a/tools/telemetry/telemetry/results/results_options.py b/tools/telemetry/telemetry/results/results_options.py

index ebb71320df805e08912ffcccf5ebc1a8d2fe11b6..82ef6b5ce9abb47af9be57e2b4d3b249d03262d6 100644

--- a/tools/telemetry/telemetry/results/results_options.py

+++ b/tools/telemetry/telemetry/results/results_options.py

@@ -117,10 +117,10 @@ def CreateResults(benchmark_metadata, options):

elif output_format == 'json':

output_formatters.append(json_output_formatter.JsonOutputFormatter(

output_stream, benchmark_metadata))

- elif output_format == 'chartjson':

+ elif options.output_format == 'chartjson':

output_formatters.append(

chart_json_output_formatter.ChartJsonOutputFormatter(

- output_stream, benchmark_metadata))

+ output_stream, benchmark_metadata, options.upload_results))

else:

# Should never be reached. The parser enforces the choices.

raise Exception('Invalid --output-format "%s". Valid choices are: %s'