tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py - Issue 545523002: [Telemetry] Add capability for values to reference external files.

Unified Diff: tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

Issue 545523002: [Telemetry] Add capability for values to reference external files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work around GPU triggered tests not knowing about trace_viewer Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/results/chart_json_output_formatter.py ('k') | tools/telemetry/telemetry/results/json_output_formatter.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

diff --git a/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py b/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

index 23a8b964f09060042455e817711e158291555aa6..b7d682cb2c56c40fcb0028c1939bc9489d4219e0 100644

--- a/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

+++ b/tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py

@@ -14,6 +14,7 @@ from telemetry.page import page_set

from telemetry.value import scalar

from telemetry.value import list_of_scalar_values

+# pylint: disable=W0212

def _MakePageSet():

ps = page_set.PageSet(file_path=os.path.dirname(__file__))

@@ -48,7 +49,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0]

summary_values = []

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -58,7 +59,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = []

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -72,7 +73,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0, v1]

summary_values = []

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -86,7 +87,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0, v1]

summary_values = []

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -102,7 +103,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = [v0, v1]

summary_values = []

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -118,7 +119,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = [v0]

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -131,7 +132,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = [v0]

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)

@@ -144,7 +145,7 @@ class ChartJsonTest(unittest.TestCase):

page_specific_values = []

summary_values = [v0]

- d = chart_json_output_formatter._ResultsAsChartDict( # pylint: disable=W0212

+ d, _ = chart_json_output_formatter._ResultsAsChartDict(

self._benchmark_metadata,

page_specific_values,

summary_values)