Per isolate package root.

runtime/bin/main.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include <stdlib.h>
 #include <string.h>
 #include <stdio.h>
 
 #include "include/dart_api.h"
 #include "include/dart_debugger_api.h"
@@ skipping 36 matching lines @@
 // and listen for a debugger to connect.
 static bool start_debugger = false;
 static const char* debug_ip = NULL;
 static int debug_port = -1;
 static const char* DEFAULT_DEBUG_IP = "127.0.0.1";
 static const int DEFAULT_DEBUG_PORT = 5858;
 
 // Value of the --package-root flag.
 // (This pointer points into an argv buffer and does not need to be
 // free'd.)
-static const char* package_root = NULL;
+static const char* commandline_package_root = NULL;
 
 
 // Global flag that is used to indicate that we want to compile all the
 // dart functions and not run anything.
 static bool has_compile_all = false;
 
 // Global flag that is used to indicate that we want to print the source code
 // for script that is being run.
 static bool has_print_script = false;
 
@@ skipping 61 matching lines @@
   return true;
 }
 
 
 static bool ProcessPackageRootOption(const char* arg,
                                      CommandLineOptions* vm_options) {
   ASSERT(arg != NULL);
   if (*arg == '\0' || *arg == '-') {
     return false;
   }
-  package_root = arg;
+  commandline_package_root = arg;
   return true;
 }
 
 
 static void* GetHashmapKeyFromString(char* key) {
   return reinterpret_cast<void*>(key);
 }
 
 
 static bool ExtractPortAndIP(const char *option_value,
@@ skipping 397 matching lines @@
     *error = strdup(Dart_GetError(result));                                    \
     *is_compile_error = Dart_IsCompilationError(result);                       \
     Dart_ExitScope();                                                          \
     Dart_ShutdownIsolate();                                                    \
     return NULL;                                                               \
   }                                                                            \
 
 // Returns true on success, false on failure.
 static Dart_Isolate CreateIsolateAndSetupHelper(const char* script_uri,
                                                 const char* main,
                                                 void* data,

[Ivan Posva, 2014/09/08 05:46:35]

The data parameter should be typed as IsolateData*.

[Anders Johnsen, 2014/09/09 06:45:43]

Done.

                                                 char** error,
                                                 bool* is_compile_error) {
   Dart_Isolate isolate =
       Dart_CreateIsolate(script_uri, main, snapshot_buffer, data, error);
   if (isolate == NULL) {
     return NULL;
   }
 
   Dart_EnterScope();
 
@@ skipping 12 matching lines @@
 
   // Load the specified application script into the newly created isolate.
 
   // Prepare builtin and its dependent libraries for use to resolve URIs.
   // The builtin library is part of the core snapshot and would already be
   // available here in the case of script snapshot loading.
   Dart_Handle builtin_lib =
       Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);
   CHECK_RESULT(builtin_lib);
 
+  IsolateData* isolate_data = reinterpret_cast<IsolateData*>(data);

[Ivan Posva, 2014/09/08 05:46:35]

Unneeded.

[Anders Johnsen, 2014/09/09 06:45:43]

Done.

+  ASSERT(isolate_data != NULL);
+  ASSERT(isolate_data->script_url != NULL);
+  const char* package_root = isolate_data->package_root;
+
   // Prepare for script loading by setting up the 'print' and 'timer'
   // closures and setting up 'package root' for URI resolution.
   result = DartUtils::PrepareForScriptLoading(package_root, builtin_lib);
   CHECK_RESULT(result);
 
-  IsolateData* isolate_data = reinterpret_cast<IsolateData*>(data);
-  ASSERT(isolate_data != NULL);
-  ASSERT(isolate_data->script_url != NULL);
   result = DartUtils::LoadScript(isolate_data->script_url, builtin_lib);
   CHECK_RESULT(result);
 
   // Run event-loop and wait for script loading to complete.
   result = Dart_RunLoop();
   CHECK_RESULT(result);
 
   Platform::SetPackageRoot(package_root);
   Dart_Handle io_lib_url = DartUtils::NewString(DartUtils::kIOLibURL);
   CHECK_RESULT(io_lib_url);
@@ skipping 21 matching lines @@
     return NULL;
   }
 
   return isolate;
 }
 
 #undef CHECK_RESULT
 
 static Dart_Isolate CreateIsolateAndSetup(const char* script_uri,
                                           const char* main,
+                                          const char* package_root,
                                           void* data, char** error) {
+  IsolateData* parent_isolate_data = reinterpret_cast<IsolateData*>(data);
   bool is_compile_error = false;
   if (script_uri == NULL) {
     if (data == NULL) {
       *error = strdup("Invalid 'callback_data' - Unable to spawn new isolate");
       return NULL;
     }
-    IsolateData* parent_isolate_data = reinterpret_cast<IsolateData*>(data);
     script_uri = parent_isolate_data->script_url;
     if (script_uri == NULL) {
       *error = strdup("Invalid 'callback_data' - Unable to spawn new isolate");
       return NULL;
     }
   }
-  IsolateData* isolate_data = new IsolateData(script_uri);
+  if (package_root == NULL) {
+    package_root = parent_isolate_data->package_root;
+  }
+  IsolateData* isolate_data = new IsolateData(script_uri, package_root);
   return CreateIsolateAndSetupHelper(script_uri,
                                      main,
                                      isolate_data,

[turnidge, 2014/09/08 19:47:00]

You are treating script_uri and package_root assymetrically here.

I see that you are tucking away script_uri and package_root in the data for
later.  But you then explicilty pass "script_uri" to CreateIsolateAndSetupHelper
but rely on isolate_data to pass in "package_root".  Instead how about you pass
in package_root as an explicit parameter? 

[Anders Johnsen, 2014/09/09 06:45:43]

It would needed to be passed both places (like script_uri). Changing, but let me
know if this is not what you meant.

                                      error,
                                      &is_compile_error);
 }
 
 
 #define CHECK_RESULT(result)                                                   \
   if (Dart_IsError(result)) {                                                  \
     *error = strdup(Dart_GetError(result));                                    \
     Dart_ExitScope();                                                          \
     Dart_ShutdownIsolate();                                                    \
     return NULL;                                                               \
   }                                                                            \
 
 static Dart_Isolate CreateServiceIsolate(void* data, char** error) {
   const char* script_uri = DartUtils::kVMServiceLibURL;
-  IsolateData* isolate_data = new IsolateData(script_uri);
+  IsolateData* isolate_data = new IsolateData(script_uri, NULL);
   Dart_Isolate isolate =
       Dart_CreateIsolate(script_uri, "main", snapshot_buffer, isolate_data,
                          error);
   if (isolate == NULL) {
     return NULL;
   }
   Dart_EnterScope();
   if (snapshot_buffer != NULL) {
     // Setup the native resolver as the snapshot does not carry it.
     Builtin::SetNativeResolver(Builtin::kBuiltinLibrary);
     Builtin::SetNativeResolver(Builtin::kIOLibrary);
   }
   // Set up the library tag handler for this isolate.
   Dart_Handle result = Dart_SetLibraryTagHandler(DartUtils::LibraryTagHandler);
   CHECK_RESULT(result);
   result = Dart_SetEnvironmentCallback(EnvironmentCallback);
   CHECK_RESULT(result);
   // Prepare builtin and its dependent libraries for use to resolve URIs.
   Dart_Handle builtin_lib =
       Builtin::LoadAndCheckLibrary(Builtin::kBuiltinLibrary);
   CHECK_RESULT(builtin_lib);
   // Prepare for script loading by setting up the 'print' and 'timer'
   // closures and setting up 'package root' for URI resolution.
-  result = DartUtils::PrepareForScriptLoading(package_root, builtin_lib);
+  result = DartUtils::PrepareForScriptLoading(commandline_package_root,
+                                              builtin_lib);

[Ivan Posva, 2014/09/08 05:46:35]

I would expect the service isolate to not expect a valid package root. The
command line package root is certainly not the right one to use.

[Anders Johnsen, 2014/09/09 06:45:43]

Will pass 'NULL' then.

   CHECK_RESULT(result);
-  Platform::SetPackageRoot(package_root);
+  Platform::SetPackageRoot(commandline_package_root);
   Dart_Handle io_lib_url = DartUtils::NewString(DartUtils::kIOLibURL);
   CHECK_RESULT(io_lib_url);
   Dart_Handle io_lib = Dart_LookupLibrary(io_lib_url);
   CHECK_RESULT(io_lib);
   Dart_Handle platform_type = DartUtils::GetDartType(DartUtils::kIOLibURL,
                                                      "_Platform");
   CHECK_RESULT(platform_type);
   Dart_Handle script_name = DartUtils::NewString("_nativeScript");
   CHECK_RESULT(script_name);
   Dart_Handle dart_script = DartUtils::NewString(script_uri);
@@ skipping 328 matching lines @@
     Dart_RegisterIsolateServiceRequestCallback(
         "io", &ServiceRequestHandler, NULL);
   }
   ASSERT(Dart_CurrentIsolate() == NULL);
 
   // Call CreateIsolateAndSetup which creates an isolate and loads up
   // the specified application script.
   char* error = NULL;
   bool is_compile_error = false;
   char* isolate_name = BuildIsolateName(script_name, "main");
-  IsolateData* isolate_data = new IsolateData(script_name);
+  IsolateData* isolate_data = new IsolateData(script_name,
+                                              commandline_package_root);
   Dart_Isolate isolate = CreateIsolateAndSetupHelper(script_name,
                                                      "main",
                                                      isolate_data,
                                                      &error,
                                                      &is_compile_error);
   if (isolate == NULL) {
     Log::PrintErr("%s\n", error);
     free(error);
     delete [] isolate_name;
     exit(is_compile_error ? kCompilationErrorExitCode : kErrorExitCode);
@@ skipping 111 matching lines @@
   exit(Process::GlobalExitCode());
 }
 
 }  // namespace bin
 }  // namespace dart
 
 int main(int argc, char** argv) {
   dart::bin::main(argc, argv);
   UNREACHABLE();
 }