mojo/public/tools/bindings/generators/mojom_js_generator.py - Issue 545433002: mojo: Generate top level enums for python bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/generators/mojom_js_generator.py

Issue 545433002: mojo: Generate top level enums for python bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unhelpful conditional Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/generators/mojom_js_generator.py

diff --git a/mojo/public/tools/bindings/generators/mojom_js_generator.py b/mojo/public/tools/bindings/generators/mojom_js_generator.py

index 16b44cd72fb0eba36f67fd6849d93dba70cd6f3e..18209977d1438b5e6a05460993f453e6291a385e 100644

--- a/mojo/public/tools/bindings/generators/mojom_js_generator.py

+++ b/mojo/public/tools/bindings/generators/mojom_js_generator.py

@@ -195,7 +195,7 @@ def TranslateConstants(token):

if token.parent_kind:

name.append(token.parent_kind.name)

if isinstance(token, mojom.EnumValue):

- name.append(token.enum_name)

+ name.append(token.enum.name)

name.append(token.name)

return ".".join(name)