Issue 54543011: Have StyleResolverParentPusher / SelectorFilter deal with references

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54543011: Have StyleResolverParentPusher / SelectorFilter deal with references (Closed)

Created:
7 years, 1 month ago by Inactive

Modified:
7 years, 1 month ago

Reviewers:
dglazkov, adamk

CC:
blink-reviews, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Have StyleResolverParentPusher / SelectorFilter deal with references Have StyleResolverParentPusher / SelectorFilter deal with references instead of pointers since those can never be null. This makes the code look safer. R=adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161643

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -36 lines)			Patch
M	Source/core/css/SelectorFilter.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/core/css/SelectorFilter.cpp	View	2 chunks	+15 lines, -15 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/css/resolver/StyleResolver.cpp	View	2 chunks	+6 lines, -8 lines	0 comments	Download
M	Source/core/dom/Element.cpp	View	5 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/54543011/1

7 years, 1 month ago (2013-11-08 19:48:47 UTC) #4

Message was sent while issue was closed.

Change committed as 161643

Expand Messages | Collapse Messages