athena/wm/window_manager_impl.cc - Issue 545393002: Adding split view divider widget.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/wm/window_manager_impl.cc

Issue 545393002: Adding split view divider widget. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing sadrul's feedback Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/wm/window_manager_impl.cc

diff --git a/athena/wm/window_manager_impl.cc b/athena/wm/window_manager_impl.cc

index 9797422ecba0da460f1de66b1ac7a9956fba91dc..73be46ede23b722e0ed721a1ca5bbff73f41f5e6 100644

--- a/athena/wm/window_manager_impl.cc

+++ b/athena/wm/window_manager_impl.cc

@@ -141,6 +141,7 @@ WindowManagerImpl::WindowManagerImpl() {

bezel_controller_.reset(new BezelController(container_.get()));

split_view_controller_.reset(

new SplitViewController(container_.get(), window_list_provider_.get()));

+ AddObserver(split_view_controller_.get());

bezel_controller_->set_left_right_delegate(split_view_controller_.get());

container_->AddPreTargetHandler(bezel_controller_.get());

title_drag_controller_.reset(new TitleDragController(container_.get(), this));

@@ -154,6 +155,7 @@ WindowManagerImpl::WindowManagerImpl() {

WindowManagerImpl::~WindowManagerImpl() {

overview_.reset();

+ RemoveObserver(split_view_controller_.get());

split_view_controller_.reset();

window_list_provider_.reset();

if (container_) {