Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issue 545353002: Fix a DCHECK triggered by DetachableResourceLoader (Closed)

Created:
6 years, 3 months ago by mmenke
Modified:
6 years, 3 months ago
Reviewers:
davidben
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a DCHECK triggered by DetachableResourceHandler under certain circumstances, when resuming a request. BUG=411228 Committed: https://crrev.com/5c27061d1d3525e38d9328cd1b80d8ebcf8720a9 Cr-Commit-Position: refs/heads/master@{#293822}

Patch Set 1 #

Patch Set 2 : Fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M content/browser/loader/detachable_resource_handler.cc View 1 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mmenke
The entirety of my coding for the week! (No, not really, but not as far ...
6 years, 3 months ago (2014-09-05 20:52:53 UTC) #2
davidben
lgtm. Nit: s/DetachableResourceLoader/DetachableResourceHandler/ :-) I guess this assumes the downstream handler always calls LogBlocked. Which ...
6 years, 3 months ago (2014-09-05 20:59:27 UTC) #3
mmenke
On 2014/09/05 20:59:27, David Benjamin wrote: > lgtm. > > Nit: s/DetachableResourceLoader/DetachableResourceHandler/ :-) > > ...
6 years, 3 months ago (2014-09-05 21:02:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/545353002/20001
6 years, 3 months ago (2014-09-08 18:48:44 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 6ca3c4d9ac6a8315b2bfb30c8b4a9916c87cf020
6 years, 3 months ago (2014-09-09 00:47:48 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5c27061d1d3525e38d9328cd1b80d8ebcf8720a9
Cr-Commit-Position: refs/heads/master@{#293822}

Powered by Google App Engine
This is Rietveld 408576698