Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(438)

Issue 545343003: Don't layout twice in ui::Compositor (Closed)

Created:
6 years, 3 months ago by enne (OOO)
Modified:
6 years, 3 months ago
Reviewers:
danakj, piman
CC:
cc-bugs_chromium.org, chromium-reviews, danakj+watch_chromium.org, jbauman+watch_chromium.org, kalyank, piman+watch_chromium.org, sievers+watch_chromium.org, Ian Vollick
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Don't layout twice in ui::Compositor In the SingleThreadProxy+SchedulerClient patch, LayerTreeHostClient::Layout is now called via DoCommit which is called via Composite(Immediately). In no cases should the embedder call Layout() manually. R=danakj@chromium.org,piman@chromium.org BUG=none Committed: https://crrev.com/3115a3df298d733cb36306b351a00f55f8452214 Cr-Commit-Position: refs/heads/master@{#293632}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M ui/compositor/compositor.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (3 generated)
enne (OOO)
OOPS I forgot to remove this when I remove the ui::Compositor changes from my SchedulerClient ...
6 years, 3 months ago (2014-09-05 23:34:50 UTC) #1
danakj
On 2014/09/05 23:34:50, enne_OOO_until_sep_22 wrote: > OOPS > > I forgot to remove this when ...
6 years, 3 months ago (2014-09-05 23:45:25 UTC) #2
piman
oops. LGTM
6 years, 3 months ago (2014-09-06 01:16:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/545343003/1
6 years, 3 months ago (2014-09-06 06:53:49 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 08:56:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enne@chromium.org/545343003/1
6 years, 3 months ago (2014-09-06 19:28:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 29294cf3d94b22a104ccd8b4e7a3799c18808a99
6 years, 3 months ago (2014-09-06 20:06:23 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:16 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3115a3df298d733cb36306b351a00f55f8452214
Cr-Commit-Position: refs/heads/master@{#293632}

Powered by Google App Engine
This is Rietveld 408576698