Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Unified Diff: pkg/analysis_server/lib/src/protocol.dart

Issue 545323002: Add error condition INVALID_OVERLAY_CHANGE to analysis server. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/protocol.dart
diff --git a/pkg/analysis_server/lib/src/protocol.dart b/pkg/analysis_server/lib/src/protocol.dart
index 1f139e06b781b40d5d29e1eb0a0ac2cf2b3b7f05..e0b19b61d50f758cad1cefb72091c418ff72e444 100644
--- a/pkg/analysis_server/lib/src/protocol.dart
+++ b/pkg/analysis_server/lib/src/protocol.dart
@@ -130,6 +130,9 @@ List<AnalysisError> _analysisErrorListFromEngine(engine.LineInfo lineInfo,
* SourceEdit.apply().
*/
String _applyEdit(String code, SourceEdit edit) {
+ if (edit.length < 0) {
+ throw new RangeError('length is negative');
+ }
return code.substring(0, edit.offset) +
edit.replacement +
code.substring(edit.end);
« no previous file with comments | « pkg/analysis_server/lib/src/generated_protocol.dart ('k') | pkg/analysis_server/test/domain_analysis_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698