Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issue 545293002: Move cast_channel API tests to extensions_unittests suite (Closed)

Created:
6 years, 3 months ago by James Cook
Modified:
6 years, 3 months ago
Reviewers:
Yoyo Zhou, Wez
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, Wez, Kevin M, mark a. foltz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move cast_channel API tests to extensions_unittests suite They don't need to run in Chrome's unit_tests BUG=397164 TEST=extensions_unittests Committed: https://crrev.com/0f9a432e5e5fe32767111f1ff4db558839852d1b Cr-Commit-Position: refs/heads/master@{#293643}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/chrome_tests_unit.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M extensions/extensions.gyp View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
James Cook
yoz, PTAL wez, just FYI about the cleanup
6 years, 3 months ago (2014-09-05 17:36:09 UTC) #2
Yoyo Zhou
LGTM
6 years, 3 months ago (2014-09-05 18:39:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/545293002/1
6 years, 3 months ago (2014-09-05 19:42:16 UTC) #5
Wez
+kmarshall, mfoltz: FYI
6 years, 3 months ago (2014-09-05 21:44:55 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 01:44:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamescook@chromium.org/545293002/1
6 years, 3 months ago (2014-09-07 00:06:24 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 9344b54ad4df6961a818e1dc5c6a7692ea946ed1
6 years, 3 months ago (2014-09-07 00:07:48 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:37 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0f9a432e5e5fe32767111f1ff4db558839852d1b
Cr-Commit-Position: refs/heads/master@{#293643}

Powered by Google App Engine
This is Rietveld 408576698