Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(642)

Unified Diff: runtime/vm/debugger_api_impl.cc

Issue 545263002: Add ActivationFrame_GetFramePointer method and test. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/debugger_api_impl.cc
diff --git a/runtime/vm/debugger_api_impl.cc b/runtime/vm/debugger_api_impl.cc
index 62d99a4dc69c3191c58e7124e2e4fd162bcc91a7..f5c0a6b2022835e9e59c10a2cd75d4159034e2c1 100644
--- a/runtime/vm/debugger_api_impl.cc
+++ b/runtime/vm/debugger_api_impl.cc
@@ -308,6 +308,19 @@ DART_EXPORT Dart_Handle Dart_ActivationFrameGetLocation(
return Api::Success();
}
+DART_EXPORT Dart_Handle Dart_ActivationFrameGetFramePointer(
+ Dart_ActivationFrame activation_frame,
+ uintptr_t* frame_pointer) {
+ Isolate* isolate = Isolate::Current();
+ DARTSCOPE(isolate);
+ CHECK_AND_CAST(ActivationFrame, frame, activation_frame);
+
+ if (frame_pointer != NULL) {
+ *frame_pointer = static_cast<uintptr_t>(frame->fp());
hausner 2014/09/05 19:16:59 This is fine. How does it play with the V8 side of
Jacob 2014/09/05 20:12:25 In blink I truncate Dart stack frame values before
+ }
+ return Api::Success();
+}
+
DART_EXPORT Dart_Handle Dart_GetFunctionOrigin(Dart_Handle function_in) {
Isolate* isolate = Isolate::Current();

Powered by Google App Engine
This is Rietveld 408576698