Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(920)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545253002: Change behavior of GrDS::AutoEffectRestort wrt GPs. (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Change behavior of GrDS::AutoEffectRestort wrt GPs. BUG=skia:2889 Committed: https://skia.googlesource.com/skia/+/9b536523cae9787f6b24ed9234c50cdf2710d67e

Patch Set 1 #

Patch Set 2 : NULL != #

Patch Set 3 : update #

Total comments: 2

Patch Set 4 : remove extra period #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -14 lines) Patch
M src/gpu/GrDrawState.h View 1 2 3 2 chunks +29 lines, -9 lines 0 comments Download
M src/gpu/GrDrawState.cpp View 1 2 2 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
bsalomon
6 years, 3 months ago (2014-09-05 15:45:53 UTC) #2
joshualitt
On 2014/09/05 15:45:53, bsalomon wrote: lgtm
6 years, 3 months ago (2014-09-05 15:49:46 UTC) #3
robertphillips
lgtm + typo https://codereview.chromium.org/545253002/diff/40001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/545253002/diff/40001/src/gpu/GrDrawState.h#newcode244 src/gpu/GrDrawState.h:244: * it will assert that the ...
6 years, 3 months ago (2014-09-05 16:05:53 UTC) #4
bsalomon
https://codereview.chromium.org/545253002/diff/40001/src/gpu/GrDrawState.h File src/gpu/GrDrawState.h (right): https://codereview.chromium.org/545253002/diff/40001/src/gpu/GrDrawState.h#newcode244 src/gpu/GrDrawState.h:244: * it will assert that the GP is not ...
6 years, 3 months ago (2014-09-05 16:10:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/545253002/60001
6 years, 3 months ago (2014-09-05 16:11:39 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-05 16:18:55 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as 9b536523cae9787f6b24ed9234c50cdf2710d67e

Powered by Google App Engine
This is Rietveld 408576698