Clean up BrowsingDataAppCacheHelper

Clean up BrowsingDataAppCacheHelper

Remove unused #includes, lower dependencies etc. in preparation for componentisation.

BUG=384873
Committed: https://crrev.com/0b803cd3388edf63c6f864d3e72932293879a6c2
Cr-Commit-Position: refs/heads/master@{#295695}

[vabr (Chromium), 2014-09-05 15:10:05]

Patchset #1 (id:1) has been deleted

[vabr (Chromium), 2014-09-05 15:10:58]

vabr@chromium.org changed reviewers:
+ bauerb@chromium.org

[vabr (Chromium), 2014-09-05 15:10:59]

Hi Bernhard,

Mind taking a look?

Thanks!
Vaclav

[Bernhard Bauer, 2014-09-05 16:15:12]

https://codereview.chromium.org/545243002/diff/20001/chrome/browser/browsing_...
File chrome/browser/browsing_data/browsing_data_appcache_helper.cc (right):

https://codereview.chromium.org/545243002/diff/20001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_appcache_helper.cc:38:
appcache_service_->GetAllAppCacheInfo(
So, what happens when this object is destroyed now?

[vabr (Chromium), 2014-09-19 12:35:47]

Hi Bernhard,

Your comment was addressed, please have another look.

Thanks!
Vaclav

https://codereview.chromium.org/545243002/diff/20001/chrome/browser/browsing_...
File chrome/browser/browsing_data/browsing_data_appcache_helper.cc (right):

https://codereview.chromium.org/545243002/diff/20001/chrome/browser/browsing_...
chrome/browser/browsing_data/browsing_data_appcache_helper.cc:38:
appcache_service_->GetAllAppCacheInfo(
On 2014/09/05 16:15:12, Bernhard Bauer wrote:
> So, what happens when this object is destroyed now?

Thanks for catching this. I was confused when first reading the
CancellableCallback definition -- it does not Cancel() itself on destruction,
and neither is Cancel() called by BrowsingDataAppCacheHelper on destruction. But
I missed that the CancellableCallback binds the wrapped callback to a weak
pointer to itself, so this effectively cancels the callback on the destruction
of CancellableCallback (and it's owner).

Therefore, putting appcache_info_callback_ back.

[Bernhard Bauer, 2014-09-19 12:52:35]

LGTM!

[vabr (Chromium), 2014-09-19 13:03:07]

The CQ bit was checked by vabr@chromium.org

[commit-bot: I haz the power, 2014-09-19 13:04:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/545243002/80001

[commit-bot: I haz the power, 2014-09-19 13:36:51]

Committed patchset #4 (id:80001) as 0b7976954e0d341ec586ffb17c0ed2de4ecb4cf4

[commit-bot: I haz the power, 2014-09-19 13:37:46]

Patchset 4 (id:??) landed as
https://crrev.com/0b803cd3388edf63c6f864d3e72932293879a6c2
Cr-Commit-Position: refs/heads/master@{#295695}