Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545233002: Video Player: Change error string when casting (Closed)

Created:
6 years, 3 months ago by yoshiki
Modified:
6 years, 3 months ago
Reviewers:
fukino
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Video Player: Change error string when casting BUG=405860 TEST=manual Committed: https://crrev.com/38394720b4497bf87b603b61f122c6cfec021eff Cr-Commit-Position: refs/heads/master@{#293705}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/file_manager/video_player/js/video_player.js View 3 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
6 years, 3 months ago (2014-09-08 07:00:35 UTC) #2
fukino
On 2014/09/08 07:00:35, yoshiki wrote: > @fukino-san, PTAL. Thanks. lgtm.
6 years, 3 months ago (2014-09-08 07:10:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/545233002/1
6 years, 3 months ago (2014-09-08 10:53:17 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 79554f5128ac1398df5e92635caa3dff4a883885
6 years, 3 months ago (2014-09-08 11:54:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:45:40 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/38394720b4497bf87b603b61f122c6cfec021eff
Cr-Commit-Position: refs/heads/master@{#293705}

Powered by Google App Engine
This is Rietveld 408576698