Issue 545203004: AnalysisCanvas drawTextBlob() override.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545203004: AnalysisCanvas drawTextBlob() override. (Closed)

Created:
6 years, 3 months ago by f(malita)

Modified:
6 years, 3 months ago

Reviewers:
reveman, jbroman, reed1

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

AnalysisCanvas drawTextBlob() override. AnalysisCanvas should be notified when drawing text using the new blob API. R=jbroman@chromium.org,reed@google.com,reveman@chromium.org BUG=412445 Committed: https://crrev.com/c4539bbf0be06e0c0fa2975260a8903a4c33dd17 Cr-Commit-Position: refs/heads/master@{#294389}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -0 lines)			Patch
	M	skia/ext/analysis_canvas.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
	M	skia/ext/analysis_canvas.cc	View		1 chunk	+9 lines, -0 lines	0 comments	Download

Total messages: 7 (1 generated)

jbroman

Good find, LGTM. It would be nice if this sort of thing generated a warning, ...

6 years, 3 months ago (2014-09-11 14:14:50 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545203004/1

6 years, 3 months ago (2014-09-11 14:28:45 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as fa80c1418134ddbafa3cc4a8131eb7f688b70030

6 years, 3 months ago (2014-09-11 15:12:17 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 15:15:57 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c4539bbf0be06e0c0fa2975260a8903a4c33dd17
Cr-Commit-Position: refs/heads/master@{#294389}