Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545203002: Improved native WebRTC logging for failing initialization of MS source (Closed)

Created:
6 years, 3 months ago by henrika (OOO until Aug 14)
Modified:
6 years, 3 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Improved native WebRTC logging for failing initialization of MS source BUG=405449 TEST=Forced WebRtcAudioCapturer::Initialize() to return false and verified log. Committed: https://crrev.com/c1b874305085e40acec1bf896d767d6c4faa7ac5 Cr-Commit-Position: refs/heads/master@{#293529}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Feedback from xians@ #

Total comments: 2

Patch Set 3 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/renderer/media/webrtc/peer_connection_dependency_factory.cc View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
no longer working on chromium
https://codereview.chromium.org/545203002/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (right): https://codereview.chromium.org/545203002/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode221 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:221: std::string log_string = base::StringPrintf( nit, const std::string https://codereview.chromium.org/545203002/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode224 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:224: ...
6 years, 3 months ago (2014-09-05 12:57:24 UTC) #2
henrika (OOO until Aug 14)
Thanks. PTAL. https://codereview.chromium.org/545203002/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (right): https://codereview.chromium.org/545203002/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode221 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:221: std::string log_string = base::StringPrintf( On 2014/09/05 12:57:23, ...
6 years, 3 months ago (2014-09-05 13:02:21 UTC) #3
no longer working on chromium
On 2014/09/05 13:02:21, henrika wrote: > Thanks. PTAL. > > https://codereview.chromium.org/545203002/diff/1/content/renderer/media/webrtc/peer_connection_dependency_factory.cc > File content/renderer/media/webrtc/peer_connection_dependency_factory.cc > ...
6 years, 3 months ago (2014-09-05 13:06:28 UTC) #4
tommi (sloooow) - chröme
https://codereview.chromium.org/545203002/diff/20001/content/renderer/media/webrtc/peer_connection_dependency_factory.cc File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (right): https://codereview.chromium.org/545203002/diff/20001/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode221 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:221: const std::string log_string = base::StringPrintf( doesn't look like you ...
6 years, 3 months ago (2014-09-05 13:09:06 UTC) #6
henrika (OOO until Aug 14)
Thanks Tommi. PTAL ;-) https://codereview.chromium.org/545203002/diff/20001/content/renderer/media/webrtc/peer_connection_dependency_factory.cc File content/renderer/media/webrtc/peer_connection_dependency_factory.cc (right): https://codereview.chromium.org/545203002/diff/20001/content/renderer/media/webrtc/peer_connection_dependency_factory.cc#newcode221 content/renderer/media/webrtc/peer_connection_dependency_factory.cc:221: const std::string log_string = base::StringPrintf( ...
6 years, 3 months ago (2014-09-05 13:11:34 UTC) #7
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-09-05 13:23:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/henrika@chromium.org/545203002/40001
6 years, 3 months ago (2014-09-05 13:26:31 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as 7965ead9bf4a812cea2b58a72d09e2b1fd034c7e
6 years, 3 months ago (2014-09-05 16:12:47 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:51 UTC) #12
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c1b874305085e40acec1bf896d767d6c4faa7ac5
Cr-Commit-Position: refs/heads/master@{#293529}

Powered by Google App Engine
This is Rietveld 408576698