Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545193006: Move SkGpuDevice.h to src/gpu (Closed)

Created:
6 years, 3 months ago by bsalomon
Modified:
6 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : remove gpu support from pdfviewer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -251 lines) Patch
M experimental/PdfViewer/pdf_viewer_main.cpp View 1 2 4 chunks +1 line, -43 lines 0 comments Download
M gyp/gpu.gypi View 1 2 chunks +1 line, -1 line 0 comments Download
D include/gpu/SkGpuDevice.h View 1 1 chunk +0 lines, -208 lines 0 comments Download
A + src/gpu/SkGpuDevice.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
bsalomon
6 years, 3 months ago (2014-09-05 19:34:28 UTC) #2
reed1
lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm lgtm ...
6 years, 3 months ago (2014-09-05 20:20:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/545193006/1
6 years, 3 months ago (2014-09-10 20:31:26 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-10 22:31:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545193006/1
6 years, 3 months ago (2014-09-10 23:04:11 UTC) #9
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-11 01:04:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545193006/20001
6 years, 3 months ago (2014-09-16 20:40:00 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.skia (http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot/builds/1665)
6 years, 3 months ago (2014-09-16 20:45:51 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545193006/40001
6 years, 3 months ago (2014-09-16 20:56:20 UTC) #17
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 21:09:18 UTC) #18
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as d99bbb61e58e8bd34db3954147ce1c9166fe4637

Powered by Google App Engine
This is Rietveld 408576698