Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 545193003: Supervised users: Add a cmdline flag and about:flags entry to enable the host blacklist (Closed)

Created:
6 years, 3 months ago by Marc Treib
Modified:
6 years, 3 months ago
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Supervised users: Add a cmdline flag and about:flags entry to enable the host blacklist BUG=410824 Committed: https://crrev.com/fd04f1559164601a5a7a52118d0cb2612d41c83e Cr-Commit-Position: refs/heads/master@{#293740}

Patch Set 1 #

Patch Set 2 : update histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Marc Treib
PTAL!
6 years, 3 months ago (2014-09-05 14:56:10 UTC) #2
Bernhard Bauer
lgtm
6 years, 3 months ago (2014-09-05 15:28:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/545193003/1
6 years, 3 months ago (2014-09-05 15:29:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/13412)
6 years, 3 months ago (2014-09-05 16:38:10 UTC) #7
Marc Treib
+asvitkine Alexei, can you please review my trivial update in histograms.xml? Thanks!
6 years, 3 months ago (2014-09-08 08:06:06 UTC) #9
Alexei Svitkine (slow)
lgtm
6 years, 3 months ago (2014-09-08 15:01:21 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/treib@chromium.org/545193003/20001
6 years, 3 months ago (2014-09-08 15:17:15 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 7504129b41b4a9966272e7181039112c8f115c0f
6 years, 3 months ago (2014-09-08 16:34:16 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:45 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fd04f1559164601a5a7a52118d0cb2612d41c83e
Cr-Commit-Position: refs/heads/master@{#293740}

Powered by Google App Engine
This is Rietveld 408576698