Issue 545163002: Unify JSEntryStub and JSConstructEntryStub, and some more code stub cleanups.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545163002: Unify JSEntryStub and JSConstructEntryStub, and some more code stub cleanups. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Unify JSEntryStub and JSConstructEntryStub, and some more code stub cleanups. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23742

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+134 lines, -331 lines)			Patch
M	src/arm/code-stubs-arm.h	View	6 chunks	+4 lines, -9 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.h	View	6 chunks	+5 lines, -12 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	3 chunks	+5 lines, -4 lines	0 comments	Download
M	src/code-stubs.h	View	90 chunks	+105 lines, -287 lines	0 comments	Download
M	src/heap/heap.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	3 chunks	+2 lines, -4 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

mvstanton

Looks good, I like the removal of boilerplate with the macros. If we eventually want ...

6 years, 3 months ago (2014-09-05 12:19:13 UTC) #2

Yang

6 years, 3 months ago (2014-09-05 15:13:03 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23742 (presubmit successful).