[turbofan] Add MachineType to Phi.

[turbofan] Add MachineType to Phi.

TEST=cctest,compiler-unittests,mjsunit
R=mstarzinger@chromium.org, titzer@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23728

[Benedikt Meurer, 2014-09-05 09:57:10]

bmeurer@chromium.org changed reviewers:
+ titzer@chromium.org

[Benedikt Meurer, 2014-09-05 09:57:10]

PTAL

Test case in progress.

[titzer, 2014-09-05 10:26:08]

https://codereview.chromium.org/545153002/diff/1/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc (right):

https://codereview.chromium.org/545153002/diff/1/src/compiler/change-lowering...
src/compiler/change-lowering.cc:114: Node* phi =
graph()->NewNode(common()->Phi(kMachAnyTagged, 2), true_value,
kTypeBool | kRepTagged

... not that it matters that much, but better to document it now.

https://codereview.chromium.org/545153002/diff/1/src/compiler/node.h
File src/compiler/node.h (right):

https://codereview.chromium.org/545153002/diff/1/src/compiler/node.h#newcode59
src/compiler/node.h:59: Node* FindProjection(int projection_index);
Can we move the changes to the Projection's static parameter type to another CL?

[Benedikt Meurer, 2014-09-05 10:50:49]

Done, PTAL

https://codereview.chromium.org/545153002/diff/1/src/compiler/change-lowering.cc
File src/compiler/change-lowering.cc (right):

https://codereview.chromium.org/545153002/diff/1/src/compiler/change-lowering...
src/compiler/change-lowering.cc:114: Node* phi =
graph()->NewNode(common()->Phi(kMachAnyTagged, 2), true_value,
On 2014/09/05 10:26:08, titzer wrote:
> kTypeBool | kRepTagged
> 
> ... not that it matters that much, but better to document it now.

Done.

https://codereview.chromium.org/545153002/diff/1/src/compiler/node.h
File src/compiler/node.h (right):

https://codereview.chromium.org/545153002/diff/1/src/compiler/node.h#newcode59
src/compiler/node.h:59: Node* FindProjection(int projection_index);
On 2014/09/05 10:26:08, titzer wrote:
> Can we move the changes to the Projection's static parameter type to another
CL?

Done.

[Michael Starzinger, 2014-09-05 11:31:48]

LGTM on the operator, the instruction-selector and the graph-builder part. I
didn't look at the lowering part.

[titzer, 2014-09-05 11:38:21]

lgtm

[Benedikt Meurer, 2014-09-05 11:44:48]

Committed patchset #3 (id:40001) manually as 23728 (presubmit successful).