Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 545103003: Adding sync integration tests to official build artifacts (Closed)

Created:
6 years, 3 months ago by David Abrahams
Modified:
6 years, 3 months ago
Reviewers:
anandc, Michael Moss
CC:
chromium-reviews, kitchen-sync_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding sync integration tests to official build artifacts Following the steps done in https://codereview.chromium.org/323163003/ Not sure how to test this, any guidance? I want the sync_integration_tests binary to be stored in official Chrome build gs:// drops just like browser_tests and other test binaries already are. Then I can set up automation to approve new releases of Sync server. BUG=411389 Committed: https://crrev.com/de3a5e8b35ad6b7452acb0502b27fb77b37e9a7c Cr-Commit-Position: refs/heads/master@{#293775}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M build/all.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/linux/TESTS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/tools/build/win/FILES.cfg View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
David Abrahams
6 years, 3 months ago (2014-09-05 18:28:34 UTC) #2
Michael Moss
lgtm
6 years, 3 months ago (2014-09-05 18:31:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/resetswitch@chromium.org/545103003/1
6 years, 3 months ago (2014-09-06 00:57:29 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5994)
6 years, 3 months ago (2014-09-06 02:43:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/resetswitch@chromium.org/545103003/1
6 years, 3 months ago (2014-09-08 18:48:31 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as 70571291b9db415c0cac655bddd8ecf8d15f6e1f
6 years, 3 months ago (2014-09-08 20:04:01 UTC) #10
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:47:50 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/de3a5e8b35ad6b7452acb0502b27fb77b37e9a7c
Cr-Commit-Position: refs/heads/master@{#293775}

Powered by Google App Engine
This is Rietveld 408576698