Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(184)

Issue 545078: Adds Russian words including U+0451 (Cyrillic Letter Io)... (Closed)

Created:
8 years, 11 months ago by Hironori Bono
Modified:
7 years, 7 months ago
Reviewers:
jungshik at Google
CC:
chromium-reviews_googlegroups.com
Base URL:
svn://chrome-svn.corp.google.com/chrome/trunk/deps/
Visibility:
Public.

Description

Adds Russian words including U+0451 (Cyrillic Letter Io) This change adds thousands of Russian words including U+0451 to our Russian dictionary. The following algorithm is used for correcting these words. 1. Collect Russian words including U+0451 and U+0401 from web; 2. Replace U+0451 with U+0435 (and U+0401 with U+0415), respectively; 3. Find the replaced word from our Russian dictionary, and; 4. If the replaced word is in our Russian dictionary, add the original word with the suffix rules for the replaced word. Even though I tried to avoid adding invalid words to our Russian dictionary as much as possible, I'm not totally sure all of them are correct. BUG=8397 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41000

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -0 lines) Patch
A third_party/hunspell128/dictionaries/ru-RU-2-0.bdic View Binary file 0 comments Download
M third_party/hunspell128/dictionaries/ru_RU.dic_delta View Binary file 0 comments Download

Messages

Total messages: 5 (0 generated)
Hironori Bono
The updated dictionary may not work with older hunpell < 1.2.8. So, I updated the ...
8 years, 11 months ago (2010-01-15 11:21:56 UTC) #1
jungshik at Google
Hi Hironori, Thank you for working on this. How many words are added by your ...
8 years, 11 months ago (2010-01-15 19:31:57 UTC) #2
Hironori Bono
Hi Jungshik, Thank you for your comments. Since this change includes 6792 Russian words, it ...
8 years, 11 months ago (2010-01-18 03:31:34 UTC) #3
Hironori Bono
Hi Jungshik, Sorry for my slow update. I have updated this change to include 2451 ...
8 years, 9 months ago (2010-03-02 09:46:18 UTC) #4
jungshik at Google
8 years, 9 months ago (2010-03-08 19:18:54 UTC) #5
LGTM !

Hi Hironori,

Sorry for my slow response. I'll trust you did the right thing with the vetting
process. Thank you for setting up the vetting process and updating the dict. 


On 2010/03/02 09:46:18, hbono wrote:
> Hi Jungshik,
> 
> Sorry for my slow update.
> I have updated this change to include 2451 words that we have confirmed as
> correct. Is it possible to review the updated one?
> 
> Regards,
> 
> Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698