Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: util/test/mac/mach_multiprocess.cc

Issue 545053003: Add exc_server_variants including UniversalMachExcServer and its test (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Address review feedback Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/util.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/test/mac/mach_multiprocess.cc
diff --git a/util/test/mac/mach_multiprocess.cc b/util/test/mac/mach_multiprocess.cc
index d78b86008559e05789c21b7456975723da31954f..569f2c278ec2bae77eeca66a2e8e001614414887 100644
--- a/util/test/mac/mach_multiprocess.cc
+++ b/util/test/mac/mach_multiprocess.cc
@@ -27,6 +27,7 @@
#include "base/rand_util.h"
#include "gtest/gtest.h"
#include "util/mach/bootstrap.h"
+#include "util/mach/mach_extensions.h"
#include "util/misc/scoped_forbid_return.h"
#include "util/test/errors.h"
#include "util/test/mac/mach_errors.h"
@@ -105,17 +106,17 @@ void MachMultiprocess::PreFork() {
}
mach_port_t MachMultiprocess::LocalPort() const {
- EXPECT_NE(static_cast<mach_port_t>(MACH_PORT_NULL), info_->local_port);
+ EXPECT_NE(kMachPortNull, info_->local_port);
return info_->local_port;
}
mach_port_t MachMultiprocess::RemotePort() const {
- EXPECT_NE(static_cast<mach_port_t>(MACH_PORT_NULL), info_->remote_port);
+ EXPECT_NE(kMachPortNull, info_->remote_port);
return info_->remote_port;
}
mach_port_t MachMultiprocess::ChildTask() const {
- EXPECT_NE(static_cast<mach_port_t>(MACH_PORT_NULL), info_->child_task);
+ EXPECT_NE(kMachPortNull, info_->child_task);
return info_->child_task;
}
« no previous file with comments | « util/mach/mach_message_server_test.cc ('k') | util/util.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698