Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545043003: ozone: dri: Implement cursor animation (Closed)

Created:
6 years, 3 months ago by spang
Modified:
6 years, 3 months ago
Reviewers:
dnicoara
CC:
chromium-reviews, rjkroege, kalyank, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

ozone: dri: Implement cursor animation This adds a timer that steps through the cursor animation. R=dnicoara BUG=343245 TEST=viewed css "wait" cursor on cros link_freon NOTRY=true Committed: https://crrev.com/8e369096567e079d70bd87ac1e4fad4f58c8fbec Cr-Commit-Position: refs/heads/master@{#294183}

Patch Set 1 #

Total comments: 3

Patch Set 2 : comments from dnicoara #

Patch Set 3 : undo early return #

Patch Set 4 : oops, undid it wrong #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -13 lines) Patch
M ui/ozone/platform/dri/dri_surface_factory.h View 1 2 3 chunks +8 lines, -1 line 0 comments Download
M ui/ozone/platform/dri/dri_surface_factory.cc View 1 2 3 5 chunks +27 lines, -10 lines 0 comments Download
M ui/ozone/platform/dri/gbm_surface_factory.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
spang
6 years, 3 months ago (2014-09-05 20:48:09 UTC) #1
spang
depends on https://codereview.chromium.org/543643003/
6 years, 3 months ago (2014-09-05 21:19:03 UTC) #2
dnicoara
lgtm https://codereview.chromium.org/545043003/diff/1/ui/ozone/platform/dri/dri_surface_factory.cc File ui/ozone/platform/dri/dri_surface_factory.cc (right): https://codereview.chromium.org/545043003/diff/1/ui/ozone/platform/dri/dri_surface_factory.cc#newcode166 ui/ozone/platform/dri/dri_surface_factory.cc:166: if (controller) { nit: Is it possible to ...
6 years, 3 months ago (2014-09-08 13:53:18 UTC) #3
spang
https://codereview.chromium.org/545043003/diff/1/ui/ozone/platform/dri/dri_surface_factory.cc File ui/ozone/platform/dri/dri_surface_factory.cc (right): https://codereview.chromium.org/545043003/diff/1/ui/ozone/platform/dri/dri_surface_factory.cc#newcode166 ui/ozone/platform/dri/dri_surface_factory.cc:166: if (controller) { On 2014/09/08 13:53:18, dnicoara wrote: > ...
6 years, 3 months ago (2014-09-08 15:15:49 UTC) #4
spang
https://codereview.chromium.org/545043003/diff/1/ui/ozone/platform/dri/dri_surface_factory.cc File ui/ozone/platform/dri/dri_surface_factory.cc (right): https://codereview.chromium.org/545043003/diff/1/ui/ozone/platform/dri/dri_surface_factory.cc#newcode166 ui/ozone/platform/dri/dri_surface_factory.cc:166: if (controller) { On 2014/09/08 15:15:49, spang wrote: > ...
6 years, 3 months ago (2014-09-10 15:22:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/spang@chromium.org/545043003/60001
6 years, 3 months ago (2014-09-10 17:07:20 UTC) #7
commit-bot: I haz the power
Committed patchset #4 (id:60001) as ccd17b93c232a35ebb47f6dea975518968ca71c0
6 years, 3 months ago (2014-09-10 17:08:57 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 17:14:03 UTC) #9
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/8e369096567e079d70bd87ac1e4fad4f58c8fbec
Cr-Commit-Position: refs/heads/master@{#294183}

Powered by Google App Engine
This is Rietveld 408576698