Issue 545033003: Drop SVG_PAINTTYPE_* values that are never used (written)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 545033003: Drop SVG_PAINTTYPE_* values that are never used (written) (Closed)

Created:
6 years, 3 months ago by fs

Modified:
6 years, 3 months ago

Reviewers:
pdr., f(malita), Stephen Chennney

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, pdr., rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Drop SVG_PAINTTYPE_* values that are never used (written) Drop SVG_PAINTTYPE_UNKNOWN and SVG_PAINTTYPE_*_ICCCOLOR since there's currently no code that sets anything to those values, and since they're no longer part of a Web-facing API. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182066

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -7 lines)			Patch
M	Source/core/rendering/style/SVGRenderStyleDefs.h	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGResource.cpp	View	2 chunks	+1 line, -3 lines	0 comments	Download
M	Source/core/rendering/svg/SVGResources.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545033003/1

6 years, 3 months ago (2014-09-16 15:20:59 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-16 16:38:43 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 182066

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages