Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(410)

Issue 545033002: Fix that switch "--disk-cache-dir" has no effect when specifying a path containing non-ascii charac… (Closed)

Created:
6 years, 3 months ago by leiyi.jp
Modified:
6 years, 3 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix that switch "--disk-cache-dir" has no effect when specifying a path containing non-ascii characters. The kDiskCacheDir(disk-cache-dir) has a *path* value, not a string that only contains ascii characters. We should use GetSwitchValuePath() to get its value instead of GetSwitchValueASCII(). R=bauerb@chromium.org BUG=410676 Committed: https://crrev.com/e85f5c68ba2514eab50abc2fabcca6e946d10a2e Cr-Commit-Position: refs/heads/master@{#294534}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M chrome/browser/prefs/command_line_pref_store.h View 2 chunks +6 lines, -0 lines 0 comments Download
M chrome/browser/prefs/command_line_pref_store.cc View 3 chunks +14 lines, -1 line 0 comments Download

Messages

Total messages: 19 (13 generated)
leiyi.jp
6 years, 3 months ago (2014-09-05 03:53:37 UTC) #1
rvargas (doing something else)
(switch reviewers)
6 years, 3 months ago (2014-09-09 23:38:02 UTC) #5
Bernhard Bauer
LGTM, thanks!
6 years, 3 months ago (2014-09-10 09:27:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545033002/1
6 years, 3 months ago (2014-09-12 02:03:16 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as cdf8689d45f83dae4ea680555cf822641b407e42
6 years, 3 months ago (2014-09-12 03:25:34 UTC) #18
commit-bot: I haz the power
6 years, 3 months ago (2014-09-12 03:28:16 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e85f5c68ba2514eab50abc2fabcca6e946d10a2e
Cr-Commit-Position: refs/heads/master@{#294534}

Powered by Google App Engine
This is Rietveld 408576698