Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 54503007: New SkRTConf macro SK_CONF_TRY_SET: no complaint on missing configuration (Closed)

Created:
7 years, 1 month ago by hal.canary
Modified:
7 years, 1 month ago
CC:
skia-review_googlegroups.com, humper, caryclark
Visibility:
Public.

Description

New SkRTConf macro SK_CONF_TRY_SET: no complaint on missing configuration SK_CONF_TRY_SET() is like SK_CONF_SET(), but doesn't complain if confname can't be found. This is useful if the SK_CONF_DECLARE is inside a source file whose linkage is dependent on the system. Internally to the SkRTConf system, SkRTConfRegistry::set() was given an additional parameter controling wanrings. A new RuntimeConfig unit test was introduced. It should run silently. In the future, it should be expanded to cover all of the SkRTConf functionality. (For example, the images.jpeg.suppressDecoderWarnings variable is defined and used only in SkImageDecoder_libjpeg.cpp, but on MacOS, we use Core Graphics via SkImageDecoder_CG.cpp - SkImageDecoder_libjpeg is never linked in. The same is true of the Windows Imaging Component on Windows.) BUG= R=reed@google.com Committed: https://code.google.com/p/skia/source/detail?r=12155

Patch Set 1 #

Total comments: 2

Patch Set 2 : whitespace change for ifdefs #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -12 lines) Patch
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkRTConf.h View 2 chunks +11 lines, -2 lines 1 comment Download
M src/utils/SkRTConf.cpp View 2 chunks +14 lines, -10 lines 0 comments Download
A tests/RuntimeConfigTest.cpp View 1 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
hal.canary
Cary, this is a fix for the bug you reported to me with SK_CONF_SET.
7 years, 1 month ago (2013-11-01 15:35:28 UTC) #1
caryclark
lgtm (with humper's approval) https://codereview.chromium.org/54503007/diff/1/tests/RuntimeConfigTest.cpp File tests/RuntimeConfigTest.cpp (right): https://codereview.chromium.org/54503007/diff/1/tests/RuntimeConfigTest.cpp#newcode19 tests/RuntimeConfigTest.cpp:19: #ifdef SK_DEVELOPER I find this ...
7 years, 1 month ago (2013-11-01 16:57:36 UTC) #2
hal.canary
https://codereview.chromium.org/54503007/diff/1/tests/RuntimeConfigTest.cpp File tests/RuntimeConfigTest.cpp (right): https://codereview.chromium.org/54503007/diff/1/tests/RuntimeConfigTest.cpp#newcode19 tests/RuntimeConfigTest.cpp:19: #ifdef SK_DEVELOPER On 2013/11/01 16:57:36, caryclark wrote: > I ...
7 years, 1 month ago (2013-11-01 17:01:18 UTC) #3
humper
On 2013/11/01 17:01:18, halcanary wrote: > https://codereview.chromium.org/54503007/diff/1/tests/RuntimeConfigTest.cpp > File tests/RuntimeConfigTest.cpp (right): > > https://codereview.chromium.org/54503007/diff/1/tests/RuntimeConfigTest.cpp#newcode19 > ...
7 years, 1 month ago (2013-11-01 19:19:35 UTC) #4
hal.canary
> ** Presubmit ERRORS ** > Since the CL is editing public API, you must ...
7 years, 1 month ago (2013-11-06 14:22:41 UTC) #5
reed1
lgtm https://codereview.chromium.org/54503007/diff/80001/include/utils/SkRTConf.h File include/utils/SkRTConf.h (right): https://codereview.chromium.org/54503007/diff/80001/include/utils/SkRTConf.h#newcode55 include/utils/SkRTConf.h:55: #define SK_CONF_SET(confname, value) \ at some point we ...
7 years, 1 month ago (2013-11-06 15:02:20 UTC) #6
hal.canary
7 years, 1 month ago (2013-11-06 15:07:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 manually as r12155 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698