Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 545013003: Adding libaries needed to build x11 naclport + refactor. (Closed)

Created:
6 years, 3 months ago by bradn
Modified:
6 years, 3 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Adding libaries needed to build x11 naclport + refactor. Adding xutils-dev for naclport of xorg-server. Adding intltool for xkeyboard-config. NOTRY=true BUG=None TEST=None R=sbc@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5e59c2c1bfb07c78d8170c9b41c6d275bb5a42f8

Patch Set 1 #

Total comments: 2

Patch Set 2 : fixc #

Patch Set 3 : intltool #

Patch Set 4 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M build/install-build-deps.sh View 1 2 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
bradn
6 years, 3 months ago (2014-09-05 16:12:57 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/545013003/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/545013003/diff/1/build/install-build-deps.sh#newcode145 build/install-build-deps.sh:145: naclports_list=="ant autoconf bison cmake gawk xutils-dev xsltproc" ==?
6 years, 3 months ago (2014-09-05 18:19:11 UTC) #2
bradn
https://codereview.chromium.org/545013003/diff/1/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/545013003/diff/1/build/install-build-deps.sh#newcode145 build/install-build-deps.sh:145: naclports_list=="ant autoconf bison cmake gawk xutils-dev xsltproc" On 2014/09/05 ...
6 years, 3 months ago (2014-09-05 19:16:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/545013003/20001
6 years, 3 months ago (2014-09-05 19:18:04 UTC) #5
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-05 21:22:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/545013003/20001
6 years, 3 months ago (2014-09-05 21:25:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/545013003/40001
6 years, 3 months ago (2014-09-06 06:03:12 UTC) #12
commit-bot: I haz the power
Failed to apply the patch.
6 years, 3 months ago (2014-09-06 06:04:39 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bradnelson@google.com/545013003/60001
6 years, 3 months ago (2014-09-06 06:09:27 UTC) #16
commit-bot: I haz the power
Failed to apply the patch.
6 years, 3 months ago (2014-09-06 06:10:57 UTC) #18
bradn
Committed patchset #4 (id:60001) manually as 5e59c2c (presubmit successful).
6 years, 3 months ago (2014-09-06 06:21:55 UTC) #19
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:42:14 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5e59c2c1bfb07c78d8170c9b41c6d275bb5a42f8
Cr-Commit-Position: refs/heads/master@{#293604}

Powered by Google App Engine
This is Rietveld 408576698