Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 544953006: Reland "Add handling for argument adaptor frames to inlining." (Closed)

Created:
6 years, 3 months ago by sigurds
Modified:
6 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev, Jarin
Project:
v8
Visibility:
Public.

Description

Reland "Add handling for argument adaptor frames to inlining." Original: https://codereview.chromium.org/573703002/ Reland Fixes: - Add deopt framestate to CollectStackTrace runtime call R=mstarzinger@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24023

Patch Set 1 #

Patch Set 2 : Reland fix: Add framestate to CollectStackTrace runtime call. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+421 lines, -156 lines) Patch
M src/compiler/ast-graph-builder.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M src/compiler/code-generator.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/compiler/code-generator.cc View 4 chunks +32 lines, -23 lines 0 comments Download
M src/compiler/common-operator.h View 4 chunks +25 lines, -9 lines 0 comments Download
M src/compiler/common-operator.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +50 lines, -21 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/instruction-selector-unittest.cc View 5 chunks +17 lines, -17 lines 0 comments Download
M src/compiler/js-inlining.h View 2 chunks +6 lines, -0 lines 0 comments Download
M src/compiler/js-inlining.cc View 8 chunks +110 lines, -10 lines 0 comments Download
M src/compiler/linkage.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/node.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node-properties.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/node-properties-inl.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/frames.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M test/cctest/cctest.status View 1 chunk +3 lines, -4 lines 0 comments Download
M test/cctest/compiler/test-codegen-deopt.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/compiler/test-js-typed-lowering.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-inlining.cc View 11 chunks +133 lines, -39 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
sigurds
PTAL, locally this one runtime call was sufficient, but let's wait for the trybots.
6 years, 3 months ago (2014-09-17 16:13:55 UTC) #1
Michael Starzinger
LGTM (on the delta between patch set #1 and #2).
6 years, 3 months ago (2014-09-17 16:32:34 UTC) #2
sigurds
6 years, 3 months ago (2014-09-18 08:57:15 UTC) #3
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as 24023 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698