Supprot V2 app: step1

Supprot V2 app: step1
 * Add AthenaAppDelegate
 * Add factory functions to create various dialogs
 * Add terminating callback to AthenaEnv 

BUG=410448
TEST=AthenaEnvTest.TerminatingCallback
TBR=sky@chromium.org, jochen@chromium.org, reed@chromium.org

Committed: https://crrev.com/480242d63b091995b58c1e21940249d91af9544f
Cr-Commit-Position: refs/heads/master@{#294123}

[oshima, 2014-09-08 21:54:11]

Patchset #1 (id:1) has been deleted

[oshima, 2014-09-08 21:54:16]

Patchset #1 (id:20001) has been deleted

[oshima, 2014-09-09 20:21:51]

Patchset #1 (id:40001) has been deleted

[oshima, 2014-09-09 20:21:58]

Patchset #1 (id:60001) has been deleted

[oshima, 2014-09-09 20:22:55]

Patchset #1 (id:80001) has been deleted

[oshima, 2014-09-09 20:23:04]

Patchset #1 (id:100001) has been deleted

[oshima, 2014-09-09 20:23:21]

Patchset #1 (id:120001) has been deleted

[oshima, 2014-09-09 20:30:07]

Patchset #1 (id:140001) has been deleted

[oshima, 2014-09-09 23:27:43]

Patchset #4 (id:210001) has been deleted

[oshima, 2014-09-09 23:28:20]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2014-09-09 23:28:32]

Patchset #3 (id:190001) has been deleted

[oshima, 2014-09-09 23:28:36]

Patchset #2 (id:170001) has been deleted

[oshima, 2014-09-09 23:28:40]

Patchset #1 (id:150001) has been deleted

[oshima, 2014-09-09 23:37:29]

Patchset #1 (id:230001) has been deleted

[Jun Mukai, 2014-09-10 00:07:11]

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
File athena/env/athena_env_impl.cc (right):

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
athena/env/athena_env_impl.cc:267: virtual void AddTerminatingCallback(const
base::Closure& closure) OVERRIDE {
Rather than bundling terminating callbacks here, it would be better to introduce
observer events (AthenaEnvObserver / OnAthenaTerminating()) and let each
AppDelegate observe the event to run the callback on terminating.

https://codereview.chromium.org/544953003/diff/250001/athena/extensions/chrom...
File athena/extensions/chrome/athena_app_delegate.h (right):

https://codereview.chromium.org/544953003/diff/250001/athena/extensions/chrom...
athena/extensions/chrome/athena_app_delegate.h:8: #include "base/callback.h"
base/callback_forward.h would be more preferable.

[Jun Mukai, 2014-09-10 00:24:30]

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
File athena/env/athena_env_impl.cc (right):

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
athena/env/athena_env_impl.cc:292: (*iter).Run();
iter->Run();

[oshima, 2014-09-10 00:47:50]

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
File athena/env/athena_env_impl.cc (right):

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
athena/env/athena_env_impl.cc:267: virtual void AddTerminatingCallback(const
base::Closure& closure) OVERRIDE {
On 2014/09/10 00:07:10, Jun Mukai wrote:
> Rather than bundling terminating callbacks here, it would be better to
introduce
> observer events (AthenaEnvObserver / OnAthenaTerminating()) and let each
> AppDelegate observe the event to run the callback on terminating.

I'd like to use callback for a couple of reasons.

1) There was a thread in chromium-dev about this, and there, a lot of people
preferred callback as a way to replace NotificationService.
2) I want to avoid having too many observers, or one observer that observes
everything.
3) It makes it a bit easier to integrate components and chrome code. Callback is
in
  base/ while observer has to be in athena/.

Reference:

https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/$20sin...

http://www.chromium.org/developers/content-module/content-api

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
athena/env/athena_env_impl.cc:292: (*iter).Run();
On 2014/09/10 00:24:30, Jun Mukai wrote:
> iter->Run();

Done.

https://codereview.chromium.org/544953003/diff/250001/athena/extensions/chrom...
File athena/extensions/chrome/athena_app_delegate.h (right):

https://codereview.chromium.org/544953003/diff/250001/athena/extensions/chrom...
athena/extensions/chrome/athena_app_delegate.h:8: #include "base/callback.h"
On 2014/09/10 00:07:11, Jun Mukai wrote:
> base/callback_forward.h would be more preferable.

This is necessary to have terminating_callback_ member variable.

[Jun Mukai, 2014-09-10 00:51:48]

lgtm

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
File athena/env/athena_env_impl.cc (right):

https://codereview.chromium.org/544953003/diff/250001/athena/env/athena_env_i...
athena/env/athena_env_impl.cc:267: virtual void AddTerminatingCallback(const
base::Closure& closure) OVERRIDE {
On 2014/09/10 00:47:49, oshima wrote:
> On 2014/09/10 00:07:10, Jun Mukai wrote:
> > Rather than bundling terminating callbacks here, it would be better to
> introduce
> > observer events (AthenaEnvObserver / OnAthenaTerminating()) and let each
> > AppDelegate observe the event to run the callback on terminating.
> 
> I'd like to use callback for a couple of reasons.
> 
> 1) There was a thread in chromium-dev about this, and there, a lot of people
> preferred callback as a way to replace NotificationService.
> 2) I want to avoid having too many observers, or one observer that observes
> everything.
> 3) It makes it a bit easier to integrate components and chrome code. Callback
is
> in
>   base/ while observer has to be in athena/.
> 
> Reference:
> 
>
https://groups.google.com/a/chromium.org/forum/#!searchin/chromium-dev/$20sin...
> 
> http://www.chromium.org/developers/content-module/content-api

Okay, in that case.

I imagine that this type of thing (implementing set of callbacks) could be in
base/ rather than here, but that could be done in another CL.

[oshima, 2014-09-10 04:40:14]

Patchset #3 (id:290001) has been deleted

[oshima, 2014-09-10 04:52:14]

Patchset #3 (id:310001) has been deleted

[oshima, 2014-09-10 05:05:34]

Patchset #3 (id:330001) has been deleted

[oshima, 2014-09-10 05:07:11]

Patchset #3 (id:350001) has been deleted

[oshima, 2014-09-10 05:10:22]

Patchset #3 (id:370001) has been deleted

[oshima, 2014-09-10 05:28:51]

Patchset #4 (id:410001) has been deleted

[oshima, 2014-09-10 05:28:58]

Patchset #3 (id:390001) has been deleted

[oshima, 2014-09-10 05:29:57]

oshima@chromium.org changed reviewers:
+ jochen@chromium.org, reed@chromium.org, sky@chromium.org

[oshima, 2014-09-10 05:34:15]

tbr'ing for following DEPS

sky -> ui/base, chrome/browser in athena/content/chrome/DEPS,
athena/extensions/chrome

jochen -> content/public/browser in athena/extensions/chrome/DEPS

reed -> SkColor.h in athena/content/public/DEPS

[oshima, 2014-09-10 05:34:22]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2014-09-10 05:34:53]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/oshima@chromium.org/544953003/450001

[commit-bot: I haz the power, 2014-09-10 06:31:48]

Committed patchset #4 (id:450001) as 211621285ac55cb119e4d8bc97a30601f24f6cea

[commit-bot: I haz the power, 2014-09-10 06:36:23]

Patchset 4 (id:??) landed as
https://crrev.com/480242d63b091995b58c1e21940249d91af9544f
Cr-Commit-Position: refs/heads/master@{#294123}