Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 544943002: X87: Make concrete classes for individual call descriptors (Closed)

Created:
6 years, 3 months ago by Jing
Modified:
6 years, 3 months ago
Reviewers:
Weiliang, mvstanton
CC:
v8-dev, danno
Base URL:
https://github.com/v8/v8.git@bleeding_edge
Project:
v8
Visibility:
Public.

Description

X87: Make concrete classes for individual call descriptors port r23639 original commit message: Make concrete classes for individual call descriptors. The ic-convention classes that hold register specifications are merged into these new call descriptor classes, which should represent a final home for that information. BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -423 lines) Patch
M src/ic/x87/access-compiler-x87.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/ic/x87/handler-compiler-x87.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/ic/x87/ic-compiler-x87.cc View 2 chunks +7 lines, -7 lines 0 comments Download
D src/ic/x87/ic-conventions-x87.cc View 1 chunk +0 lines, -38 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 13 chunks +32 lines, -32 lines 0 comments Download
M src/x87/builtins-x87.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +7 lines, -11 lines 0 comments Download
M src/x87/debug-x87.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 24 chunks +52 lines, -52 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 2 chunks +274 lines, -226 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M src/x87/lithium-x87.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/x87/lithium-x87.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Jing
6 years, 3 months ago (2014-09-05 01:50:34 UTC) #2
Weiliang
lgtm
6 years, 3 months ago (2014-09-05 02:10:54 UTC) #3
Weiliang
6 years, 3 months ago (2014-09-05 02:13:02 UTC) #4
Committed as r23708

Powered by Google App Engine
This is Rietveld 408576698