Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
54493010:
Use title on Mac file select dialog. (Closed)
|
Created:
7 years, 1 month ago by vandebo (ex-Chrome) Modified:
7 years, 1 month ago Reviewers:
Nico CC:
chromium-reviews, Jeffrey Yasskin Base URL:
svn://svn.chromium.org/chrome/trunk/src Visibility:
Public. |
DescriptionUse title on Mac file select dialog.
Title is not displayed in the file select dialog, whereas Message is.
BUG=NONE
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233149
Patch Set 1 #
Messages
Total messages: 13 (0 generated)
You can see what this looks like in this SO question: http://stackoverflow.com/q/11745745/943619
Hm. The title shows up in the title bar if the panel runs as standalone window, not as sheet. We always show it as a sheet, so it's true that the title is never visible. It's very unusual to have open/save panels with a message on mac. What's this motivated by? It looks like most callers pass an empty string for the title – which dialogs will this impact in practice?
On 2013/11/01 22:25:18, Nico wrote: > Hm. The title shows up in the title bar if the panel runs as standalone window, > not as sheet. We always show it as a sheet, so it's true that the title is never > visible. > > It's very unusual to have open/save panels with a message on mac. What's this > motivated by? > > It looks like most callers pass an empty string for the title – which dialogs > will this impact in practice? I chased down a number of the places that would be affected by this (below) - Looks like mostly extension code and download code. The motivation is a new picker where an app can request the user add a media gallery without additional confirmation from the user. Privacy team wants to ensure that the dialog has descriptive text if the user cares to read it. https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/me... https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui... https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui... https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ex... https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ex... https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui... https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/fi...
On 2013/11/01 22:41:31, vandebo wrote: > On 2013/11/01 22:25:18, Nico wrote: > > Hm. The title shows up in the title bar if the panel runs as standalone > window, > > not as sheet. We always show it as a sheet, so it's true that the title is > never > > visible. > > > > It's very unusual to have open/save panels with a message on mac. What's this > > motivated by? > > > > It looks like most callers pass an empty string for the title – which dialogs > > will this impact in practice? > > I chased down a number of the places that would be affected by this (below) - > Looks like mostly extension code and download code. The motivation is a new > picker where an app can request the user add a media gallery without additional > confirmation from the user. Privacy team wants to ensure that the dialog has > descriptive text if the user cares to read it. > > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/me... > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui... > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui... > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ex... > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ex... > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui... > https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/fi... Happy to loop you into the conversation if you are interested.
Does privacy team think users read text like this? This lgtm, but if users complain about text on their dialogs we have to think of something smarter. On Fri, Nov 1, 2013 at 3:41 PM, <vandebo@chromium.org> wrote: > On 2013/11/01 22:25:18, Nico wrote: > >> Hm. The title shows up in the title bar if the panel runs as standalone >> > window, > >> not as sheet. We always show it as a sheet, so it's true that the title is >> > never > >> visible. >> > > It's very unusual to have open/save panels with a message on mac. What's >> this >> motivated by? >> > > It looks like most callers pass an empty string for the title – which >> dialogs >> will this impact in practice? >> > > I chased down a number of the places that would be affected by this > (below) - > Looks like mostly extension code and download code. The motivation is a > new > picker where an app can request the user add a media gallery without > additional > confirmation from the user. Privacy team wants to ensure that the dialog > has > descriptive text if the user cares to read it. > > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/media_**galleries/media_galleries_** > dialog_controller.cc&cl=GROK&**l=216<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/media_galleries/media_galleries_dialog_controller.cc&cl=GROK&l=216> > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/ui/webui/**options/browser_options_** > handler.cc&cl=GROK&l=1224<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui/webui/options/browser_options_handler.cc&cl=GROK&l=1224> > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/ui/webui/**options/chromeos/change_** > picture_options_handler.cc&cl=**GROK&l=172<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc&cl=GROK&l=172> > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/extensions/**api/developer_private/** > developer_private_api.cc&l=**1190<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc&l=1190> > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/extensions/**api/developer_private/** > developer_private_api.cc&l=828<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc&l=828> > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/ui/webui/**extensions/extension_settings_** > handler.cc&cl=GROK&l=970<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc&cl=GROK&l=970> > https://code.google.com/p/**chromium/codesearch/#chromium/** > src/chrome/browser/file_**select_helper.cc&cl=GROK&l=404<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/file_select_helper.cc&cl=GROK&l=404> > > https://codereview.chromium.**org/54493010/<https://codereview.chromium.org/5... > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2013/11/01 22:44:06, Nico wrote: > Does privacy team think users read text like this? I made exactly that argument today, but have not seen a reply. > This lgtm, but if users complain about text on their dialogs we have to > think of something smarter. Thanks. I'll wait until after the branch cut to commit this. > On Fri, Nov 1, 2013 at 3:41 PM, <mailto:vandebo@chromium.org> wrote: > > > On 2013/11/01 22:25:18, Nico wrote: > > > >> Hm. The title shows up in the title bar if the panel runs as standalone > >> > > window, > > > >> not as sheet. We always show it as a sheet, so it's true that the title is > >> > > never > > > >> visible. > >> > > > > It's very unusual to have open/save panels with a message on mac. What's > >> this > >> motivated by? > >> > > > > It looks like most callers pass an empty string for the title – which > >> dialogs > >> will this impact in practice? > >> > > > > I chased down a number of the places that would be affected by this > > (below) - > > Looks like mostly extension code and download code. The motivation is a > > new > > picker where an app can request the user add a media gallery without > > additional > > confirmation from the user. Privacy team wants to ensure that the dialog > > has > > descriptive text if the user cares to read it. > > > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > src/chrome/browser/media_**galleries/media_galleries_** > > > dialog_controller.cc&cl=GROK&**l=216<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/media_galleries/media_galleries_dialog_controller.cc&cl=GROK&l=216> > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > src/chrome/browser/ui/webui/**options/browser_options_** > > > handler.cc&cl=GROK&l=1224<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui/webui/options/browser_options_handler.cc&cl=GROK&l=1224> > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > src/chrome/browser/ui/webui/**options/chromeos/change_** > > > picture_options_handler.cc&cl=**GROK&l=172<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc&cl=GROK&l=172> > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > src/chrome/browser/extensions/**api/developer_private/** > > > developer_private_api.cc&l=**1190<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc&l=1190> > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > src/chrome/browser/extensions/**api/developer_private/** > > > developer_private_api.cc&l=828<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/extensions/api/developer_private/developer_private_api.cc&l=828> > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > src/chrome/browser/ui/webui/**extensions/extension_settings_** > > > handler.cc&cl=GROK&l=970<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/ui/webui/extensions/extension_settings_handler.cc&cl=GROK&l=970> > > https://code.google.com/p/**chromium/codesearch/#chromium/** > > > src/chrome/browser/file_**select_helper.cc&cl=GROK&l=404<https://code.google.com/p/chromium/codesearch/#chromium/src/chrome/browser/file_select_helper.cc&cl=GROK&l=404> > > > > > https://codereview.chromium.**org/54493010/%3Chttps://codereview.chromium.org...> > > > > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:chromium-reviews+unsubscribe@chromium.org.
On Fri, Nov 1, 2013 at 3:44 PM, Nico Weber <thakis@chromium.org> wrote: > Does privacy team think users read text like this? The alternative to some form of warning here was a warning in the install dialog, which I think is even less likely to get noticed at the relevant time, or an intermediate pop-up before the dialog, which is annoying and is probably also ignored, so I suggested this option. It would, of course, be good to get some evidence from a UX study on this... > This lgtm, but if users complain about text on their dialogs we have to > think of something smarter. We could imagine having separate |title| and |message| arguments, with an explicit warning in the API that the title isn't always shown to users, while the message may be intrusive. > On Fri, Nov 1, 2013 at 3:41 PM, <vandebo@chromium.org> wrote: >> >> On 2013/11/01 22:25:18, Nico wrote: >>> >>> Hm. The title shows up in the title bar if the panel runs as standalone >> >> window, >>> >>> not as sheet. We always show it as a sheet, so it's true that the title >>> is >> >> never >>> >>> visible. >> >> >>> It's very unusual to have open/save panels with a message on mac. What's >>> this >>> motivated by? >> >> >>> It looks like most callers pass an empty string for the title – which >>> dialogs >>> will this impact in practice? >> >> >> I chased down a number of the places that would be affected by this >> (below) - >> Looks like mostly extension code and download code. The motivation is a >> new >> picker where an app can request the user add a media gallery without >> additional >> confirmation from the user. Privacy team wants to ensure that the dialog >> has >> descriptive text if the user cares to read it. >> >> https://codereview.chromium.org/54493010/ > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On Fri, Nov 1, 2013 at 4:41 PM, Jeffrey Yasskin <jyasskin@chromium.org>wrote: > On Fri, Nov 1, 2013 at 3:44 PM, Nico Weber <thakis@chromium.org> wrote: > > Does privacy team think users read text like this? > > The alternative to some form of warning here was a warning in the > install dialog, which I think is even less likely to get noticed at > the relevant time, or an intermediate pop-up before the dialog, which > is annoying and is probably also ignored, so I suggested this option. > It would, of course, be good to get some evidence from a UX study on > this... > Or no text. What's the text supposed to say? > > > This lgtm, but if users complain about text on their dialogs we have to > > think of something smarter. > > We could imagine having separate |title| and |message| arguments, with > an explicit warning in the API that the title isn't always shown to > users, while the message may be intrusive. > > > On Fri, Nov 1, 2013 at 3:41 PM, <vandebo@chromium.org> wrote: > >> > >> On 2013/11/01 22:25:18, Nico wrote: > >>> > >>> Hm. The title shows up in the title bar if the panel runs as standalone > >> > >> window, > >>> > >>> not as sheet. We always show it as a sheet, so it's true that the title > >>> is > >> > >> never > >>> > >>> visible. > >> > >> > >>> It's very unusual to have open/save panels with a message on mac. > What's > >>> this > >>> motivated by? > >> > >> > >>> It looks like most callers pass an empty string for the title – which > >>> dialogs > >>> will this impact in practice? > >> > >> > >> I chased down a number of the places that would be affected by this > >> (below) - > >> Looks like mostly extension code and download code. The motivation is a > >> new > >> picker where an app can request the user add a media gallery without > >> additional > >> confirmation from the user. Privacy team wants to ensure that the dialog > >> has > >> descriptive text if the user cares to read it. > >> > >> https://codereview.chromium.org/54493010/ > > > > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On Fri, Nov 1, 2013 at 4:42 PM, Nico Weber <thakis@chromium.org> wrote: > On Fri, Nov 1, 2013 at 4:41 PM, Jeffrey Yasskin <jyasskin@chromium.org> > wrote: >> >> On Fri, Nov 1, 2013 at 3:44 PM, Nico Weber <thakis@chromium.org> wrote: >> > Does privacy team think users read text like this? >> >> The alternative to some form of warning here was a warning in the >> install dialog, which I think is even less likely to get noticed at >> the relevant time, or an intermediate pop-up before the dialog, which >> is annoying and is probably also ignored, so I suggested this option. >> It would, of course, be good to get some evidence from a UX study on >> this... > > > Or no text. What's the text supposed to say? The exact text isn't decided, I think, but the meaning we'd like to convey is that Foobar App gets to read media files under this directory until you uninstall it. Or "read and write", if that's the option the app picked. Right now, there's an intermediate dialog that says, "FoobarApp can access media in these locations" (or "access and change"), and then you click an "Add location" button to get a dialog whose title is "Add Media Gallery by Directory". See https://chrome.google.com/webstore/detail/media-gallery-sample/lidepfgfmameop.... The G+ photos UI folks want to be able to get to the directory picker in a single click, but some of the privacy folks are worried that users might not understand the kind of access they're granting or that it's permanent access to the future contents of the whole directory, rather than, say, just for this session or just the current contents. Given no text in the dialog, engedy@ was pushing for an install warning, which I think is really bad from a "Don't be Android's permissions list" perspective. Personally, I'd be fine with no dialog text and no install warning, but dialog text is the current compromise, which I'm reluctant to question. But we can definitely cc you into the main thread if you want to help question it. Jeffrey To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On Fri, Nov 1, 2013 at 5:11 PM, Jeffrey Yasskin <jyasskin@chromium.org>wrote: > On Fri, Nov 1, 2013 at 4:42 PM, Nico Weber <thakis@chromium.org> wrote: > > On Fri, Nov 1, 2013 at 4:41 PM, Jeffrey Yasskin <jyasskin@chromium.org> > > wrote: > >> > >> On Fri, Nov 1, 2013 at 3:44 PM, Nico Weber <thakis@chromium.org> wrote: > >> > Does privacy team think users read text like this? > >> > >> The alternative to some form of warning here was a warning in the > >> install dialog, which I think is even less likely to get noticed at > >> the relevant time, or an intermediate pop-up before the dialog, which > >> is annoying and is probably also ignored, so I suggested this option. > >> It would, of course, be good to get some evidence from a UX study on > >> this... > > > > > > Or no text. What's the text supposed to say? > > The exact text isn't decided, I think, but the meaning we'd like to > convey is that Foobar App gets to read media files under this > directory until you uninstall it. Or "read and write", if that's the > option the app picked. > > Right now, there's an intermediate dialog that says, "FoobarApp can > access media in these locations" (or "access and change"), and then > you click an "Add location" button to get a dialog whose title is "Add > Media Gallery by Directory". See > > https://chrome.google.com/webstore/detail/media-gallery-sample/lidepfgfmameop... > . > Isn't that the normal permissions UI flow? Is the plan to get rid of the normal permissions UI? > > The G+ photos UI folks want to be able to get to the directory picker > in a single click, but some of the privacy folks are worried that > users might not understand the kind of access they're granting or that > it's permanent access to the future contents of the whole directory, > rather than, say, just for this session or just the current contents. > Given no text in the dialog, engedy@ was pushing for an install > warning, which I think is really bad from a "Don't be Android's > permissions list" perspective. > > Personally, I'd be fine with no dialog text and no install warning, > but dialog text is the current compromise, which I'm reluctant to > question. But we can definitely cc you into the main thread if you > want to help question it. > > Jeffrey > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On Fri, Nov 1, 2013 at 5:16 PM, Nico Weber <thakis@chromium.org> wrote: > On Fri, Nov 1, 2013 at 5:11 PM, Jeffrey Yasskin <jyasskin@chromium.org> > wrote: >> >> On Fri, Nov 1, 2013 at 4:42 PM, Nico Weber <thakis@chromium.org> wrote: >> > On Fri, Nov 1, 2013 at 4:41 PM, Jeffrey Yasskin <jyasskin@chromium.org> >> > wrote: >> >> >> >> On Fri, Nov 1, 2013 at 3:44 PM, Nico Weber <thakis@chromium.org> wrote: >> >> > Does privacy team think users read text like this? >> >> >> >> The alternative to some form of warning here was a warning in the >> >> install dialog, which I think is even less likely to get noticed at >> >> the relevant time, or an intermediate pop-up before the dialog, which >> >> is annoying and is probably also ignored, so I suggested this option. >> >> It would, of course, be good to get some evidence from a UX study on >> >> this... >> > >> > >> > Or no text. What's the text supposed to say? >> >> The exact text isn't decided, I think, but the meaning we'd like to >> convey is that Foobar App gets to read media files under this >> directory until you uninstall it. Or "read and write", if that's the >> option the app picked. >> >> Right now, there's an intermediate dialog that says, "FoobarApp can >> access media in these locations" (or "access and change"), and then >> you click an "Add location" button to get a dialog whose title is "Add >> Media Gallery by Directory". See >> >> https://chrome.google.com/webstore/detail/media-gallery-sample/lidepfgfmameop.... > > > Isn't that the normal permissions UI flow? Is the plan to get rid of the > normal permissions UI? There are many permissions UIs. I'm not talking about the install warning UI that says "Access photos ... from your computer." That's associated with the allAutoAccess permission, and adds a Chrome-defined set of directories on installation. I'm talking about the subsequent dialog that pops up if you click "Select Galleries..." inside the app. >> The G+ photos UI folks want to be able to get to the directory picker >> in a single click, but some of the privacy folks are worried that >> users might not understand the kind of access they're granting or that >> it's permanent access to the future contents of the whole directory, >> rather than, say, just for this session or just the current contents. >> Given no text in the dialog, engedy@ was pushing for an install >> warning, which I think is really bad from a "Don't be Android's >> permissions list" perspective. >> >> Personally, I'd be fine with no dialog text and no install warning, >> but dialog text is the current compromise, which I'm reluctant to >> question. But we can definitely cc you into the main thread if you >> want to help question it. >> >> Jeffrey > > To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/54493010/1
Message was sent while issue was closed.
Change committed as 233149 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
