Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(612)

Unified Diff: net/disk_cache/backend_unittest.cc

Issue 544923002: Remove the tracing cache backend. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@preventry
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/disk_cache/cache_creator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/disk_cache/backend_unittest.cc
diff --git a/net/disk_cache/backend_unittest.cc b/net/disk_cache/backend_unittest.cc
index 9adcc733be7b2e6f34cb8dbbe3d2520684266e9a..4f4a442aa1ee95e2be79a8a6a78b4628e03e996b 100644
--- a/net/disk_cache/backend_unittest.cc
+++ b/net/disk_cache/backend_unittest.cc
@@ -29,7 +29,6 @@
#include "net/disk_cache/simple/simple_entry_format.h"
#include "net/disk_cache/simple/simple_test_util.h"
#include "net/disk_cache/simple/simple_util.h"
-#include "net/disk_cache/tracing/tracing_cache_backend.h"
#include "testing/gtest/include/gtest/gtest.h"
#if defined(OS_WIN)
@@ -127,7 +126,6 @@ class DiskCacheBackendTest : public DiskCacheTestWithCache {
void BackendDisable2();
void BackendDisable3();
void BackendDisable4();
- void TracingBackendBasics();
};
int DiskCacheBackendTest::GeneratePendingIO(net::TestCompletionCallback* cb) {
@@ -3150,40 +3148,6 @@ TEST_F(DiskCacheBackendTest, ShaderCacheUpdateRankForExternalCacheHit) {
entry->Close();
}
-void DiskCacheBackendTest::TracingBackendBasics() {
- InitCache();
- cache_.reset(new disk_cache::TracingCacheBackend(cache_.Pass()));
- cache_impl_ = NULL;
- EXPECT_EQ(net::DISK_CACHE, cache_->GetCacheType());
- if (!simple_cache_mode_) {
- EXPECT_EQ(0, cache_->GetEntryCount());
- }
-
- net::TestCompletionCallback cb;
- disk_cache::Entry* entry = NULL;
- EXPECT_NE(net::OK, OpenEntry("key", &entry));
- EXPECT_TRUE(NULL == entry);
-
- ASSERT_EQ(net::OK, CreateEntry("key", &entry));
- EXPECT_TRUE(NULL != entry);
-
- disk_cache::Entry* same_entry = NULL;
- ASSERT_EQ(net::OK, OpenEntry("key", &same_entry));
- EXPECT_TRUE(NULL != same_entry);
-
- if (!simple_cache_mode_) {
- EXPECT_EQ(1, cache_->GetEntryCount());
- }
- entry->Close();
- entry = NULL;
- same_entry->Close();
- same_entry = NULL;
-}
-
-TEST_F(DiskCacheBackendTest, TracingBackendBasics) {
- TracingBackendBasics();
-}
-
// The Simple Cache backend requires a few guarantees from the filesystem like
// atomic renaming of recently open files. Those guarantees are not provided in
// general on Windows.
@@ -3271,13 +3235,6 @@ TEST_F(DiskCacheBackendTest, SimpleCacheAppCacheOnlyDoomAll) {
BackendDoomAll();
}
-TEST_F(DiskCacheBackendTest, SimpleCacheTracingBackendBasics) {
- SetSimpleCacheMode();
- TracingBackendBasics();
- // TODO(pasko): implement integrity checking on the Simple Backend.
- DisableIntegrityCheck();
-}
-
TEST_F(DiskCacheBackendTest, SimpleCacheOpenMissingFile) {
SetSimpleCacheMode();
InitCache();
« no previous file with comments | « no previous file | net/disk_cache/cache_creator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698