Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 544923002: Remove the tracing cache backend. (Closed)

Created:
6 years, 3 months ago by gavinp
Modified:
6 years, 3 months ago
Reviewers:
pasko, clamy
CC:
chromium-reviews, cbentzel+watch_chromium.org, gavinp+disk_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@preventry
Project:
chromium
Visibility:
Public.

Description

Remove the tracing cache backend. While working on issue 410276, in particular in https://codereview.chromium.org/542733002/ , I had to update the tracing cache backend. Why? Does anyone use it? Let's remove it instead. R=pasko@chromium.org,clamy@chromium.org BUG=None Committed: https://crrev.com/b8af58ec40a0a122a5effa74958c00b2513bd660 Cr-Commit-Position: refs/heads/master@{#293505}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -456 lines) Patch
M net/disk_cache/backend_unittest.cc View 4 chunks +0 lines, -43 lines 0 comments Download
M net/disk_cache/cache_creator.cc View 1 chunk +0 lines, -4 lines 0 comments Download
D net/disk_cache/tracing/tracing_cache_backend.h View 1 chunk +0 lines, -84 lines 0 comments Download
D net/disk_cache/tracing/tracing_cache_backend.cc View 1 chunk +0 lines, -317 lines 0 comments Download
M net/net.gyp View 2 chunks +0 lines, -6 lines 0 comments Download
M net/net.gypi View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
gavinp
Egor: PTAL, -500 lines is a productive week! Let's attribute -250 to each of us. ...
6 years, 3 months ago (2014-09-05 01:21:40 UTC) #2
pasko
LGTM Thank you. I am somewhat upset that I did not manage to do it ...
6 years, 3 months ago (2014-09-05 09:26:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/544923002/1
6 years, 3 months ago (2014-09-05 11:04:50 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as aa4ad8dbd1abd884e50bd2c925b0d6c6cd77f20b
6 years, 3 months ago (2014-09-05 12:15:37 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8af58ec40a0a122a5effa74958c00b2513bd660
Cr-Commit-Position: refs/heads/master@{#293505}

Powered by Google App Engine
This is Rietveld 408576698