Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Issue 544913003: Revert of Check to ensure PowerObservers are added and removed on the same thread (Closed)

Created:
6 years, 3 months ago by dcheng
Modified:
6 years, 3 months ago
Reviewers:
brettw, Nico, bajones, scottmg
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of Check to ensure PowerObservers are added and removed on the same thread (patchset #7 id:120001 of https://codereview.chromium.org/502003003/) Reason for revert: Causing failures on Mac try jobs: ExtensionServiceTest.ExternalExtensionAutoAcknowledgement (run #1): [ RUN ] ExtensionServiceTest.ExternalExtensionAutoAcknowledgement [8427:1799:0904/211500:4724222818698:FATAL:power_monitor.cc(38)] Check failed: obs->power_monitor_thread_checker_. Original issue's description: > Check to ensure PowerObservers are added and removed on the same thread > > This behavior is required by ObserverListThreadSafe and may leads to crashes if not followed > > BUG=404767 > > Committed: https://chromium.googlesource.com/chromium/src/+/518c46fbba70c91169bfc0c64b542f06e56b3915 TBR=thakis@chromium.org,brettw@chromium.org,scottmg@chromium.org,bajones@chromium.org NOTREECHECKS=true NOTRY=true BUG=404767 Committed: https://crrev.com/5b9e04fc7c694535d2cc21710d7f7c688700648f Cr-Commit-Position: refs/heads/master@{#293448}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -37 lines) Patch
M base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M base/base.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M base/power_monitor/power_monitor.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M base/power_monitor/power_observer.h View 2 chunks +2 lines, -13 lines 0 comments Download
D base/power_monitor/power_observer.cc View 1 chunk +0 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
dcheng
Created Revert of Check to ensure PowerObservers are added and removed on the same thread
6 years, 3 months ago (2014-09-05 05:04:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/544913003/1
6 years, 3 months ago (2014-09-05 05:05:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 4f4f127b8469a50847c5cb921a8846c15e58b6b6
6 years, 3 months ago (2014-09-05 05:07:36 UTC) #3
bajones
On 2014/09/05 05:07:36, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 3 months ago (2014-09-05 13:59:16 UTC) #4
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:07 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5b9e04fc7c694535d2cc21710d7f7c688700648f
Cr-Commit-Position: refs/heads/master@{#293448}

Powered by Google App Engine
This is Rietveld 408576698