Issue 544883002: Reset the default work_area when start observing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 544883002: Reset the default work_area when start observing. (Closed)

Created:
6 years, 3 months ago by Jun Mukai

Modified:
6 years, 3 months ago

Reviewers:
stevenjb

CC:
chromium-reviews, kalyank, sadrul, ben+ash_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Reset the default work_area when start observing. In OOBE screen, shelf is not yet ready fully so that work_area_ isn't set well. It needs to be initialized here. BUG=401743 R=stevenjb@chromium.org TEST=manually Committed: https://crrev.com/64f7e297357ccdaf77a62854b36947bd3b339fb4 Cr-Commit-Position: refs/heads/master@{#293435}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	ash/system/web_notification/ash_popup_alignment_delegate.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mukai@chromium.org/544883002/1

6 years, 3 months ago (2014-09-04 22:50:52 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as 615b634d479e6f0b274b41a9866130661b8a01dc

6 years, 3 months ago (2014-09-05 04:33:00 UTC) #5

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:36:42 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/64f7e297357ccdaf77a62854b36947bd3b339fb4
Cr-Commit-Position: refs/heads/master@{#293435}