policy: Remove ProfilePolicyConnector's dependency on other service factories.

policy: Remove ProfilePolicyConnector's dependency on other service factories.

Dependencies to User (via UserManager) and to CloudPolicyManager (via UserCloudPolicyManagerFactory*) are now injected by the ProfilePolicyConnectorFactory.

BUG=312660
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232867

[pneubeck (no reviews), 2013-10-31 11:12:45]

That other CL https://codereview.chromium.org/24153012/ grew just too large,
splitting it into reasonable hunks. I verified that it's identical to that other
CL where possible.

This one should be good for review. PTAL.

[pneubeck (no reviews), 2013-10-31 12:37:28]

On 2013/10/31 11:12:45, pneubeck wrote:
> That other CL https://codereview.chromium.org/24153012/ grew just too large,
> splitting it into reasonable hunks. I verified that it's identical to that
other
> CL where possible.
> 
> This one should be good for review. PTAL.

damn it... this doesn't work of course #@!$
because the prefs are not ready at construction time...

[pneubeck (no reviews), 2013-11-04 08:38:23]

good for review.

[Joao da Silva, 2013-11-04 09:46:52]

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
File chrome/browser/policy/profile_policy_connector.cc (right):

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector.cc:22: #include
"chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h"
not needed, include chrome/browser/policy/cloud/cloud_policy_manager.h instead

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector.cc:29: #include
"chrome/browser/policy/cloud/user_cloud_policy_manager.h"
not needed

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
File chrome/browser/policy/profile_policy_connector_factory.cc (right):

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector_factory.cc:97: #else
This else breaks when ENABLE_CONFIGURATION_POLICY is not set. The #if needs to
break into 2 #ifs, like for the #includes above.

[pneubeck (no reviews), 2013-11-04 13:11:52]

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
File chrome/browser/policy/profile_policy_connector.cc (right):

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector.cc:22: #include
"chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos.h"
On 2013/11/04 09:46:52, Joao da Silva wrote:
> not needed, include chrome/browser/policy/cloud/cloud_policy_manager.h instead

Done.

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector.cc:29: #include
"chrome/browser/policy/cloud/user_cloud_policy_manager.h"
On 2013/11/04 09:46:52, Joao da Silva wrote:
> not needed

Done.

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
File chrome/browser/policy/profile_policy_connector_factory.cc (right):

https://codereview.chromium.org/54483004/diff/220001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector_factory.cc:97: #else
On 2013/11/04 09:46:52, Joao da Silva wrote:
> This else breaks when ENABLE_CONFIGURATION_POLICY is not set. The #if needs to
> break into 2 #ifs, like for the #includes above.

Done.

[Joao da Silva, 2013-11-04 13:17:56]

lgtm after fixing the #include

https://codereview.chromium.org/54483004/diff/280001/chrome/browser/policy/pr...
File chrome/browser/policy/profile_policy_connector.cc (right):

https://codereview.chromium.org/54483004/diff/280001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector.cc:11: #include
"chrome/browser/chromeos/policy/cloud_policy_manager.h"
Should be "chrome/browser/policy/cloud/cloud_policy_manager.h"

[pneubeck (no reviews), 2013-11-04 13:21:02]

https://codereview.chromium.org/54483004/diff/280001/chrome/browser/policy/pr...
File chrome/browser/policy/profile_policy_connector.cc (right):

https://codereview.chromium.org/54483004/diff/280001/chrome/browser/policy/pr...
chrome/browser/policy/profile_policy_connector.cc:11: #include
"chrome/browser/chromeos/policy/cloud_policy_manager.h"
On 2013/11/04 13:17:56, Joao da Silva wrote:
> Should be "chrome/browser/policy/cloud/cloud_policy_manager.h"

Doh.
Done.

[commit-bot: I haz the power, 2013-11-04 13:22:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/54483004/390001

[commit-bot: I haz the power, 2013-11-04 13:40:49]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-04 14:10:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/54483004/570001

[commit-bot: I haz the power, 2013-11-04 14:38:02]

Sorry for I got bad news for ya.
Compile failed with a clobber build on ios_dbg_simulator.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=ios_dbg_si...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-04 15:07:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/54483004/750001

[commit-bot: I haz the power, 2013-11-04 17:45:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/54483004/750001

[commit-bot: I haz the power, 2013-11-05 01:04:58]

Change committed as 232867