athena/activity/public/activity_factory.h - Issue 544813002: Support V1 app

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: athena/activity/public/activity_factory.h

Issue 544813002: Support V1 app (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: athena/activity/public/activity_factory.h

diff --git a/athena/activity/public/activity_factory.h b/athena/activity/public/activity_factory.h

index 91f1ec79bcfac04aeff112ab1652bbf4186a0d06..a8ca4af5cfff745366043d0a672704dbf54098a1 100644

--- a/athena/activity/public/activity_factory.h

+++ b/athena/activity/public/activity_factory.h

@@ -33,8 +33,10 @@ class ATHENA_EXPORT ActivityFactory {

virtual ~ActivityFactory() {}

- // Create an activity of a web page.

+ // Create an activity of a web page. If |title| is empty, the title will be

+ // obtained from the web contents.

virtual Activity* CreateWebActivity(content::BrowserContext* browser_context,

+ const base::string16& title,

const GURL& url) = 0;

// Create an activity of an app with |app_window| for app shell environemnt.