Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Unified Diff: chrome/browser/ui/extensions/application_launch.cc

Issue 544813002: Support V1 app (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/extensions/application_launch.cc
diff --git a/chrome/browser/ui/extensions/application_launch.cc b/chrome/browser/ui/extensions/application_launch.cc
index d25a019cf5d4c4c89131353ca1145d5993ea8f96..86b6eb7d3393441486ca3226012a02200b288eac 100644
--- a/chrome/browser/ui/extensions/application_launch.cc
+++ b/chrome/browser/ui/extensions/application_launch.cc
@@ -123,33 +123,6 @@ const Extension* GetExtension(const AppLaunchParams& params) {
ExtensionRegistry::TERMINATED);
}
-// Get the launch URL for a given extension, with optional override/fallback.
-// |override_url|, if non-empty, will be preferred over the extension's
-// launch url.
-GURL UrlForExtension(const Extension* extension,
- const GURL& override_url) {
- if (!extension)
- return override_url;
-
- GURL url;
- if (!override_url.is_empty()) {
- DCHECK(extension->web_extent().MatchesURL(override_url) ||
- override_url.GetOrigin() == extension->url());
- url = override_url;
- } else {
- url = extensions::AppLaunchInfo::GetFullLaunchURL(extension);
- }
-
- // For extensions lacking launch urls, determine a reasonable fallback.
- if (!url.is_valid()) {
- url = extensions::ManifestURL::GetOptionsPage(extension);
- if (!url.is_valid())
- url = GURL(chrome::kChromeUIExtensionsURL);
- }
-
- return url;
-}
-
ui::WindowShowState DetermineWindowShowState(
Profile* profile,
extensions::LaunchContainer container,
@@ -467,3 +440,26 @@ bool CanLaunchViaEvent(const extensions::Extension* extension) {
extensions::Feature* feature = feature_provider->GetFeature("app.runtime");
return feature->IsAvailableToExtension(extension).is_available();
}
+
+GURL UrlForExtension(const Extension* extension, const GURL& override_url) {
+ if (!extension)
+ return override_url;
+
+ GURL url;
+ if (!override_url.is_empty()) {
+ DCHECK(extension->web_extent().MatchesURL(override_url) ||
+ override_url.GetOrigin() == extension->url());
+ url = override_url;
+ } else {
+ url = extensions::AppLaunchInfo::GetFullLaunchURL(extension);
+ }
+
+ // For extensions lacking launch urls, determine a reasonable fallback.
+ if (!url.is_valid()) {
+ url = extensions::ManifestURL::GetOptionsPage(extension);
+ if (!url.is_valid())
+ url = GURL(chrome::kChromeUIExtensionsURL);
+ }
+
+ return url;
+}

Powered by Google App Engine
This is Rietveld 408576698