Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(11)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: athena/extensions/chrome/DEPS
Issue
544813002
:
Support V1 app (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase
Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
athena/activity/activity_manager_unittest.cc
athena/activity/public/activity_factory.h
athena/content/content_activity_factory.h
athena/content/content_activity_factory.cc
athena/content/content_app_model_builder.cc
athena/content/web_activity.h
athena/content/web_activity.cc
athena/extensions/chrome/DEPS
athena/extensions/chrome/extensions_delegate_impl.cc
athena/home/home_card_unittest.cc
athena/main/placeholder.cc
athena/main/url_search_provider.cc
athena/test/sample_activity_factory.h
athena/test/sample_activity_factory.cc
chrome/browser/ui/extensions/application_launch.h
chrome/browser/ui/extensions/application_launch.cc
View unified diff
|
Download patch
« athena/content/web_activity.cc
('K') |
« athena/content/web_activity.cc
('k') |
athena/extensions/chrome/extensions_delegate_impl.cc »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 include_rules = [
1 include_rules = [
2
"+athena/activity/public",
2 "+chrome/browser",
3 "+chrome/browser",
3 "+chrome/common/extensions",
4 "+chrome/common/extensions",
4 "+extensions/browser",
5 "+extensions/browser",
5 "+net/base",
6 "+net/base",
6 ]
7 ]
7
8
specific_include_rules = {
9
"athena_apps_client\.cc": [
10
# TODO(oshima): Remove this dependency.
11
"+athena/activity/public"
12
],
13
}
14
OLD
NEW
« athena/content/web_activity.cc
('K') |
« athena/content/web_activity.cc
('k') |
athena/extensions/chrome/extensions_delegate_impl.cc »
('j') |
no next file with comments »
Issue 544813002: Support V1 app (Closed)
Created 6 years, 3 months ago by oshima
Modified 6 years, 3 months ago
Reviewers: Jun Mukai, miket_OOO, sadrul
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 6
This is Rietveld
408576698