Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 544813002: Support V1 app (Closed)

Created:
6 years, 3 months ago by oshima
Modified:
6 years, 3 months ago
Reviewers:
miket_OOO, Jun Mukai, sadrul
CC:
chromium-reviews, darin-cc_chromium.org, jam, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Support V1 app BUG=410446 TEST=manual. launch webstore app from home card. Committed: https://crrev.com/d74622266bc6eba7cecd1b036c166a6b252dc07f Cr-Commit-Position: refs/heads/master@{#293527}

Patch Set 1 #

Total comments: 2

Patch Set 2 : addressed comment #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : fix test #

Patch Set 5 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -50 lines) Patch
M athena/activity/activity_manager_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M athena/activity/public/activity_factory.h View 1 chunk +3 lines, -1 line 0 comments Download
M athena/content/content_activity_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M athena/content/content_activity_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
M athena/content/content_app_model_builder.cc View 1 chunk +2 lines, -1 line 0 comments Download
M athena/content/web_activity.h View 1 2 3 4 3 chunks +5 lines, -1 line 0 comments Download
M athena/content/web_activity.cc View 1 2 3 4 3 chunks +7 lines, -2 lines 2 comments Download
M athena/extensions/chrome/DEPS View 1 chunk +1 line, -8 lines 0 comments Download
M athena/extensions/chrome/extensions_delegate_impl.cc View 1 2 2 chunks +22 lines, -1 line 0 comments Download
M athena/home/home_card_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M athena/main/placeholder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/main/url_search_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M athena/test/sample_activity_factory.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M athena/test/sample_activity_factory.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/extensions/application_launch.cc View 2 chunks +23 lines, -27 lines 0 comments Download

Messages

Total messages: 23 (7 generated)
oshima
6 years, 3 months ago (2014-09-04 21:29:31 UTC) #2
oshima
mukai-> everything miket -> chrome/browser/ui/extensions
6 years, 3 months ago (2014-09-04 21:41:25 UTC) #3
miket_OOO
I believe that the c/b/u/e method's implementation is identical and that the only change there ...
6 years, 3 months ago (2014-09-04 21:46:15 UTC) #4
Jun Mukai
https://codereview.chromium.org/544813002/diff/1/athena/extensions/chrome/extensions_delegate_impl.cc File athena/extensions/chrome/extensions_delegate_impl.cc (right): https://codereview.chromium.org/544813002/diff/1/athena/extensions/chrome/extensions_delegate_impl.cc#newcode99 athena/extensions/chrome/extensions_delegate_impl.cc:99: std::string app_name = extension LaunchApp early-exits if |extension| is ...
6 years, 3 months ago (2014-09-04 21:47:12 UTC) #5
oshima
https://codereview.chromium.org/544813002/diff/1/athena/extensions/chrome/extensions_delegate_impl.cc File athena/extensions/chrome/extensions_delegate_impl.cc (right): https://codereview.chromium.org/544813002/diff/1/athena/extensions/chrome/extensions_delegate_impl.cc#newcode99 athena/extensions/chrome/extensions_delegate_impl.cc:99: std::string app_name = extension On 2014/09/04 21:47:12, Jun Mukai ...
6 years, 3 months ago (2014-09-04 22:13:55 UTC) #6
Jun Mukai
lgtm with a nit. https://codereview.chromium.org/544813002/diff/20001/athena/extensions/chrome/extensions_delegate_impl.cc File athena/extensions/chrome/extensions_delegate_impl.cc (right): https://codereview.chromium.org/544813002/diff/20001/athena/extensions/chrome/extensions_delegate_impl.cc#newcode16 athena/extensions/chrome/extensions_delegate_impl.cc:16: #include "chrome/browser/web_applications/web_app.h" You don't have ...
6 years, 3 months ago (2014-09-04 22:20:53 UTC) #7
oshima
https://codereview.chromium.org/544813002/diff/20001/athena/extensions/chrome/extensions_delegate_impl.cc File athena/extensions/chrome/extensions_delegate_impl.cc (right): https://codereview.chromium.org/544813002/diff/20001/athena/extensions/chrome/extensions_delegate_impl.cc#newcode16 athena/extensions/chrome/extensions_delegate_impl.cc:16: #include "chrome/browser/web_applications/web_app.h" On 2014/09/04 22:20:53, Jun Mukai wrote: > ...
6 years, 3 months ago (2014-09-04 22:25:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/544813002/40001
6 years, 3 months ago (2014-09-04 22:26:46 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/11122) mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/10330)
6 years, 3 months ago (2014-09-05 02:33:41 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/544813002/60001
6 years, 3 months ago (2014-09-05 06:09:54 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/12628) android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/5566) ios_dbg_simulator ...
6 years, 3 months ago (2014-09-05 06:15:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oshima@chromium.org/544813002/80001
6 years, 3 months ago (2014-09-05 14:40:52 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 70a7430fadacb4babe1a41fdc68297155382e1e8
6 years, 3 months ago (2014-09-05 15:43:14 UTC) #19
sadrul
https://codereview.chromium.org/544813002/diff/80001/athena/content/web_activity.cc File athena/content/web_activity.cc (right): https://codereview.chromium.org/544813002/diff/80001/athena/content/web_activity.cc#newcode431 athena/content/web_activity.cc:431: // TODO(oshima): Use title set by the web contents. ...
6 years, 3 months ago (2014-09-05 15:48:26 UTC) #21
oshima
https://codereview.chromium.org/544813002/diff/80001/athena/content/web_activity.cc File athena/content/web_activity.cc (right): https://codereview.chromium.org/544813002/diff/80001/athena/content/web_activity.cc#newcode431 athena/content/web_activity.cc:431: // TODO(oshima): Use title set by the web contents. ...
6 years, 3 months ago (2014-09-05 16:45:27 UTC) #22
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:39:48 UTC) #23
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/d74622266bc6eba7cecd1b036c166a6b252dc07f
Cr-Commit-Position: refs/heads/master@{#293527}

Powered by Google App Engine
This is Rietveld 408576698