Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 544773002: Fix a bug in QuicHttpStream::Close in which response_status_ was not being set. This would cause th… (Closed)

Created:
6 years, 3 months ago by Ryan Hamilton
Modified:
6 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fix a bug in QuicHttpStream::Close in which response_status_ was not being set. This would cause the ReadResponseHeaders method to return OK even though the response headers was NULL. BUG=409871 Committed: https://crrev.com/11a114a82dff4d591f6c197f49b60c7c0a3525c9 Cr-Commit-Position: refs/heads/master@{#293377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M net/quic/quic_http_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +20 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Ryan Hamilton
6 years, 3 months ago (2014-09-04 18:02:26 UTC) #2
ramant (doing other things)
lgtm
6 years, 3 months ago (2014-09-04 18:08:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/544773002/1
6 years, 3 months ago (2014-09-04 19:13:15 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 2dcd2d2ca03397f096722081a3697e3f6ebddfe8
6 years, 3 months ago (2014-09-04 23:43:11 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:34:04 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/11a114a82dff4d591f6c197f49b60c7c0a3525c9
Cr-Commit-Position: refs/heads/master@{#293377}

Powered by Google App Engine
This is Rietveld 408576698