src/IceRegAlloc.cpp - Issue 544713002: Subzero: Make sure register preferences obey register class constraints.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceRegAlloc.cpp

Issue 544713002: Subzero: Make sure register preferences obey register class constraints. (Closed) Base URL: https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceRegAlloc.cpp

diff --git a/src/IceRegAlloc.cpp b/src/IceRegAlloc.cpp

index 10a02a3ee381dfd44c8574a75e16b735f3c56cf3..ce08c6a83c23cf9a9a5e1485a8c60e8591b16040 100644

--- a/src/IceRegAlloc.cpp

+++ b/src/IceRegAlloc.cpp

@@ -233,6 +233,7 @@ void LinearScan::scan(const llvm::SmallBitVector &RegMaskFull) {

: Variable::NoRegister;

bool AllowedToOverlap = Cur.Var->getRegisterOverlap() &&

PreferReg != Variable::NoRegister &&

+ RegMask[PreferReg] &&

!PrecoloredUnhandled[PreferReg];

if (PreferReg != Variable::NoRegister &&

(AllowedToOverlap || Free[PreferReg])) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »