Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 54463011: QUIC - Made AckFrameInfo a struct. (Closed)

Created:
7 years, 1 month ago by ramant (doing other things)
Modified:
7 years, 1 month ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

QUIC - Made AckFrameInfo a struct. Thanks Ryan for catching this. R=rch@chromium.org NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234671

Patch Set 1 #

Patch Set 2 : merging with tip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M net/quic/quic_framer.h View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
ramant (doing other things)
7 years, 1 month ago (2013-11-01 23:32:21 UTC) #1
Ryan Hamilton
lgtm
7 years, 1 month ago (2013-11-03 22:28:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/54463011/1
7 years, 1 month ago (2013-11-03 22:29:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97013
7 years, 1 month ago (2013-11-04 00:44:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/54463011/1
7 years, 1 month ago (2013-11-11 03:02:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) nacl_integration http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=187848
7 years, 1 month ago (2013-11-11 03:53:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/54463011/1
7 years, 1 month ago (2013-11-11 03:58:02 UTC) #7
commit-bot: I haz the power
Step "update" is always a major failure. Look at the try server FAQ for more ...
7 years, 1 month ago (2013-11-11 16:48:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/54463011/380003
7 years, 1 month ago (2013-11-11 21:46:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/54463011/380003
7 years, 1 month ago (2013-11-12 23:30:27 UTC) #10
commit-bot: I haz the power
7 years, 1 month ago (2013-11-13 00:17:47 UTC) #11
Message was sent while issue was closed. 
Change committed as 234671

Powered by Google App Engine
This is Rietveld 408576698