Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Issue 54463009: Link LinuxInputMethodContextFactory instead of skipping a call to its SetInstance(). (Closed)

Created:
7 years, 1 month ago by Yuki
Modified:
7 years, 1 month ago
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, James Su, jochen+watch_chromium.org
Visibility:
Public.

Description

Link LinuxInputMethodContextFactory instead of skipping a call to its SetInstance(). This is a better solution for long term for http://crrev.com/44453003 . BUG=133476 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=233534

Patch Set 1 #

Patch Set 2 : Reverted changes in shell_aura.cc #

Patch Set 3 : Synced. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M ui/base/ime/ime.gypi View 1 chunk +4 lines, -0 lines 0 comments Download
M ui/views/linux_ui/linux_ui.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
Yuki
Hi Vignatti, I think this solves the same problem you fixed in a slightly better ...
7 years, 1 month ago (2013-11-01 12:34:00 UTC) #1
vignatti (out of this project)
On 2013/11/01 12:34:00, Yuki wrote: > Hi Vignatti, > > I think this solves the ...
7 years, 1 month ago (2013-11-01 15:56:18 UTC) #2
Elliot Glaysher
lgtm
7 years, 1 month ago (2013-11-01 17:55:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/40001
7 years, 1 month ago (2013-11-02 14:15:39 UTC) #4
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34128
7 years, 1 month ago (2013-11-02 14:35:08 UTC) #5
Yuki
Nona, could you review this CL as an owner of ui/base/ime ?
7 years, 1 month ago (2013-11-03 05:57:09 UTC) #6
Yuki
Just as a friendly reminder. nona@, could you review this CL as an owner of ...
7 years, 1 month ago (2013-11-06 02:20:56 UTC) #7
Seigo Nonaka
lgtm, I'm sorry for late response.
7 years, 1 month ago (2013-11-06 02:41:25 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/40001
7 years, 1 month ago (2013-11-06 02:49:35 UTC) #9
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) check_deps, content_browsertests, nacl_integration, sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=185045
7 years, 1 month ago (2013-11-06 04:44:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/40001
7 years, 1 month ago (2013-11-06 05:26:39 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94655
7 years, 1 month ago (2013-11-06 09:17:20 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/40001
7 years, 1 month ago (2013-11-06 09:20:38 UTC) #13
commit-bot: I haz the power
Retried try job too often on linux_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_aura&number=94763
7 years, 1 month ago (2013-11-06 12:27:16 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/470001
7 years, 1 month ago (2013-11-06 12:33:10 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=220583
7 years, 1 month ago (2013-11-06 17:01:14 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/470001
7 years, 1 month ago (2013-11-07 02:44:00 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=221128
7 years, 1 month ago (2013-11-07 05:09:51 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukishiino@chromium.org/54463009/470001
7 years, 1 month ago (2013-11-07 06:18:38 UTC) #19
commit-bot: I haz the power
7 years, 1 month ago (2013-11-07 07:51:15 UTC) #20
Message was sent while issue was closed.
Change committed as 233534

Powered by Google App Engine
This is Rietveld 408576698