Source/core/html/track/TextTrackCue.cpp - Issue 54463002: Make WebVTTParser::collectTimeStamp static

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/track/TextTrackCue.cpp

Issue 54463002: Make WebVTTParser::collectTimeStamp static (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/track/TextTrackCue.cpp

diff --git a/Source/core/html/track/TextTrackCue.cpp b/Source/core/html/track/TextTrackCue.cpp

index 3621d02da3e80996efbe601325db4f712025350e..fcd83dc4699206aed7ad0445b2f663b2951bd6c2 100644

--- a/Source/core/html/track/TextTrackCue.cpp

+++ b/Source/core/html/track/TextTrackCue.cpp

@@ -791,7 +791,7 @@ void TextTrackCue::markFutureAndPastNodes(ContainerNode* root, double previousTi

if (child->nodeName() == timestampTag) {

unsigned position = 0;

String timestamp = child->nodeValue();

- double currentTimestamp = WebVTTParser::create(0, document())->collectTimeStamp(timestamp, &position);

+ double currentTimestamp = WebVTTParser::collectTimeStamp(timestamp, &position);

ASSERT(currentTimestamp != -1);

if (currentTimestamp > movieTime)

« no previous file with comments | « no previous file | Source/core/html/track/WebVTTParser.h » ('j') | no next file with comments »