Issue 54463002: Make WebVTTParser::collectTimeStamp static

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 54463002: Make WebVTTParser::collectTimeStamp static (Closed)

Created:
7 years, 1 month ago by fs

Modified:
7 years, 1 month ago

Reviewers:
Nate Chapin, jochen (gone - plz use gerrit)

CC:
blink-reviews, dglazkov+blink, nessy, vcarbune.chromium, philipj_slow, adamk+blink_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Make WebVTTParser::collectTimeStamp static This function is independent of internal WebVTTParser state, while being used outside of the actual parser. BUG=305317 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=161059

Patch Set 1 #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	Source/core/html/track/TextTrackCue.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	Source/core/html/track/WebVTTParser.h	View		2 chunks	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/54463002/1

7 years, 1 month ago (2013-10-31 10:27:33 UTC) #3

commit-bot: I haz the power

Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=14923

7 years, 1 month ago (2013-10-31 11:54:44 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/54463002/1

7 years, 1 month ago (2013-10-31 12:55:57 UTC) #5

Message was sent while issue was closed.

Change committed as 161059

Expand Messages | Collapse Messages