Issue 544613002: Remove dead code for inline string hashing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 544613002: Remove dead code for inline string hashing. (Closed)

Created:
6 years, 3 months ago by Yang

Modified:
6 years, 3 months ago

Reviewers:
Benedikt Meurer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Remove dead code for inline string hashing. This has become obsolete since hydrogenized StringAdd. R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23689

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -442 lines)			Patch
M	src/arm/code-stubs-arm.h	View	1 chunk	+0 lines, -13 lines	0 comments	Download
M	src/arm/code-stubs-arm.cc	View	1 chunk	+0 lines, -42 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/arm64/code-stubs-arm64.cc	View	1 chunk	+0 lines, -61 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.h	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1 chunk	+0 lines, -68 lines	0 comments	Download
M	src/x64/code-stubs-x64.h	View	1 chunk	+0 lines, -16 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	1 chunk	+0 lines, -59 lines	0 comments	Download
M	test/cctest/test-hashing.cc	View	3 chunks	+0 lines, -153 lines	0 comments	Download

Total messages: 3 (0 generated)

Benedikt Meurer

Great, I wanted to get rid of that crap since forever. LGTM

6 years, 3 months ago (2014-09-04 12:02:49 UTC) #2

Yang

6 years, 3 months ago (2014-09-04 12:15:23 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 23689 (presubmit successful).