Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 544603002: mojo: Move initialization of the embedder in java. (Closed)

Created:
6 years, 3 months ago by qsr
Modified:
6 years, 3 months ago
Reviewers:
ppi
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

mojo: Move initialization of the embedder in java. The embedder was initialized in the constructor of CoreImpl. This is not correct, because when it will be used in Chromium, the embedder is initialized by the native code. This remove the initialization from CoreImpl. Instead, for tests, initialize it when loading the native library. R=ppi@chromium.org Committed: https://crrev.com/009487f75b3905bf759c8b4430fed474f3d5b04e Cr-Commit-Position: refs/heads/master@{#293475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M mojo/android/javatests/init_library.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/android/system/core_impl.cc View 2 chunks +0 lines, -7 lines 0 comments Download
M mojo/android/system/src/org/chromium/mojo/system/impl/CoreImpl.java View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
qsr
6 years, 3 months ago (2014-09-04 11:30:00 UTC) #1
ppi
lgtm
6 years, 3 months ago (2014-09-04 11:43:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/544603002/1
6 years, 3 months ago (2014-09-04 11:52:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/544603002/1
6 years, 3 months ago (2014-09-04 15:26:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/43744)
6 years, 3 months ago (2014-09-04 18:52:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qsr@chromium.org/544603002/1
6 years, 3 months ago (2014-09-05 08:19:28 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1) as 58ffd3812a2a49e7dcd201c1eaebe6c0e85e70f1
6 years, 3 months ago (2014-09-05 08:21:07 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:37:58 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/009487f75b3905bf759c8b4430fed474f3d5b04e
Cr-Commit-Position: refs/heads/master@{#293475}

Powered by Google App Engine
This is Rietveld 408576698